The new qa.ubuntu.com shouldn't have comments enabled on static pages
Bug #663124 reported by
Alex Lourie
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu QA Website |
Triaged
|
Low
|
Unassigned | ||
Bug Description
The new qa.ubuntu.com shouldn't have comments enabled on static pages. For example, the "Bugs" page is static, but is has a comments form under the content.
Related branches
lp://staging/~alourie/ubuntu-qa-website/fix_bug_663124
- Ara Pulido (community): Disapprove
-
Diff: 813 lines (+809/-0)1 file modifiedpages.xml (+809/-0)
lp://staging/~alourie/ubuntu-qa-website/fix_bug__wp-theme_663124
- Ara Pulido (community): Approve
-
Diff: 22 lines (+1/-2)2 files modifiedpage.php (+0/-1)
style.css (+1/-1)
- Ara Pulido (community): Disapprove
-
Diff: 2315 lines (+2176/-0)18 files modified404.php (+22/-0)
archive.php (+64/-0)
comments-popup.php (+124/-0)
comments.php (+104/-0)
footer.php (+24/-0)
functions.php (+211/-0)
header.php (+59/-0)
ie.css (+5/-0)
image.php (+61/-0)
images/header-img.php (+82/-0)
index.php (+45/-0)
page.php (+21/-0)
rtl.css (+127/-0)
search.php (+44/-0)
sidebar.php (+70/-0)
single.php (+35/-0)
style.css (+1010/-0)
theme.js (+68/-0)
| tags: | added: qa-website |
| description: | updated |
| Changed in ubuntu-qa-website: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
Revision history for this message
| Ara Pulido (ara) wrote | #1 |
| tags: |
added: qa-wordpress removed: qa-website |
| Changed in ubuntu-qa-website: | |
| status: | Confirmed → Triaged |
| summary: |
- The new qa.ubuntu.com should have comments enabled on static pages + The new qa.ubuntu.com shouldn't have comments enabled on static pages |
| Changed in ubuntu-qa-website: | |
| status: | Triaged → Fix Released |
| status: | Fix Released → Triaged |
To post a comment you must log in.
Alex, thanks for suggestion. The bug report is correct, I agree that pages shouldn't contain comments.
But this change should be made in the theme, and not the content. If we change the content to do that, and then we add a new page, it will add the comments for that page.
I have to reject your patch, but feel free to propose a merge to the theme that solves this issue.
Thanks!