rsync config can be overwritten by cs:nrpe, losing max connections, etc.
Bug #1890760 reported by
Paul Collins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Mirror Charm |
New
|
Undecided
|
Unassigned | ||
Bug Description
cs:nrpe clobbers /etc/rsyncd.conf, which is where the connection limit is set by ubuntu-mirror, as well as timeout and motd file.
Related branches
~pjdc/charm-nrpe/+git/nrpe-charm:rsync-merge-config
- Tom Haddon: Approve
- Canonical IS Reviewers: Pending requested
-
Diff: 10 lines (+1/-0)1 file modifiedfiles/rsyncd.conf (+1/-0)
~pjdc/ubuntu-mirror-charm/+git/ubuntu-mirror-charm:rsync-global-config
- Alexandre Gomes: Approve
- Canonical IS Reviewers: Pending requested
-
Diff: 41 lines (+8/-2)3 files modifiedhooks/hooks.py (+1/-0)
templates/rsync-base-cfg.tmpl (+1/-2)
templates/rsync-mirrors-cfg.tmpl (+6/-0)
To post a comment you must log in.
After a lot of close reading of rsyncd.conf and, finally, rsync's code, worked out that a) max connections is a per-module parameter, BUT b) by default it uses a *shared* lock file, which makes it a global limit.
Since it's a module parameter, we can set it in each module (see linked ubuntu-mirror-charm MP).
This leaves the problem of our other rsyncd.conf setting, the genuinely global "motd file". Global options cannot be set from files that are &included. However, they *can* be set from files that are &merged! (See linked nrpe-charm MP.)