Charm attempts to own /etc/rsyncd.conf, but so does nrpe
Bug #1885064 reported by
Barry Price
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| NRPE Charm |
Fix Released
|
Medium
|
Unassigned | ||
| Ubuntu Mirror Charm |
Confirmed
|
Undecided
|
Unassigned | ||
Bug Description
Both the ubuntu-mirror charm and the nrpe charm assume that they, and only they, own /etc/rsyncd.conf
If the ubuntu-mirror charm wins the race, you get "max connections" set.
If the nrpe charm wins the race, you do not.
At least one, if not both, should really parse and amend the file with what's needed, rather than assuming exclusive ownership.
Related branches
~pjdc/charm-nrpe/+git/nrpe-charm:rsync-merge-config
- Tom Haddon (community): Approve
- Canonical IS Reviewers: Pending requested
-
Diff: 10 lines (+1/-0)1 file modifiedfiles/rsyncd.conf (+1/-0)
| Changed in charm-nrpe: | |
| status: | New → Confirmed |
| Changed in ubuntu-mirror-charm: | |
| status: | New → Confirmed |
| Changed in charm-nrpe: | |
| status: | Confirmed → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Paul Collins (pjdc) wrote | #1 |
| Changed in charm-nrpe: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
I've mostly solved this problem by moving "max connections" and "timeout" into the module settings. ("max connections" is a per-module setting, but because we don't change "lock file", all modules share the limit).
The only setting we can't handle in this manner is "motd file". The linked branch address this by adding "&merge /etc/rsync-juju.d", which will pull in all *.inc files from that directory and, unlike &included files, let them affect the global config.