lxc 3.0.3-0ubuntu1~18.04.1 ADT test failure with B/5.4 kernels (device_add_remove_test)

Bug #1886790 reported by Kleber Sacilotto de Souza
44
This bug affects 5 people
Affects Status Importance Assigned to Milestone
ubuntu-kernel-tests
New
Undecided
Unassigned
lxc (Ubuntu)
Fix Released
Undecided
Unassigned
Bionic
Fix Released
Medium
Unassigned

Bug Description

[ Impact ]

 * The device_add_remove_test test fails on the affected series (e.g. Bionic).
 * Having the test fixed for the affected series (for example, Bionic) will allow us to run the LXC test suite without maintaining local changes for this test.

[ Test Plan ]

 * Run the affected test on an affected series (e.g. Bionic).
 * The test should pass.

[ Where problems could occur ]

 * The regression risk is very low, and the changes only affect the tests, so the regression scope is minimal.

[ Other Info ]

Upstream drop of network_latency: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c3082a674f46fe49383b157882c41dfabaa37113
Related to: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1848587

Original bug report:

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/amd64/l/lxc/20200706_183234_ca65f@/log.gz
    arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/arm64/l/lxc/20200706_172136_71b68@/log.gz
    ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/ppc64el/l/lxc/20200706_191938_cedac@/log.gz
    s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-bionic/bionic/s390x/l/lxc/20200706_163359_98d4d@/log.gz

The failing test seems to be:

FAIL: lxc-tests: lxc-test-device-add-remove (0s)
---
Adding /dev/network_latency to the container (device_add_remove_test) failed...
---

This is a regression from the 4.15/5.3 to 5.4 kernels in Bionic. Note that this testcase is successful on Focal with the same kernel version.

Related branches

tags: added: kernel-adt-failure
description: updated
summary: - lxc 3.0.3-0ubuntu1~18.04.1 ADT test failure with linux-hwe-5.4
- 5.4.0-41.45~18.04.1
+ lxc 3.0.3-0ubuntu1~18.04.1 ADT test failure with 5.4 kernels in Bionic
description: updated
description: updated
Changed in lxc (Ubuntu Bionic):
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote : Re: lxc 3.0.3-0ubuntu1~18.04.1 ADT test failure with 5.4 kernels in Bionic

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in lxc (Ubuntu Bionic):
status: New → Confirmed
Changed in lxc (Ubuntu):
status: New → Confirmed
Revision history for this message
Christian Brauner (cbrauner) wrote :

This is a bug we fixed in our stable-3.0 branch and is fixed in the Ubuntu lxc 3.0.4 packages. See
https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1848587
and specifically this commit:

commit 11fc6882f7bfd40fbcda6a3a7f7c1bca50df3f2b
Author: Christian Brauner <email address hidden>
Date: Mon Nov 18 15:08:22 2019 +0100

    tests: use /dev/loop-control instead of /dev/network_latency

    BugLink: https://bugs.launchpad.net/bugs/1848587

    The latter device has been removed apparently.

Bionic didn't get the 3.0.4 upgrade? That seems odd.

Changed in lxc (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

This is a testcase issue, so I'm lowering the importance to 'Medium'.

Changed in lxc (Ubuntu Bionic):
importance: High → Medium
summary: - lxc 3.0.3-0ubuntu1~18.04.1 ADT test failure with 5.4 kernels in Bionic
+ lxc 3.0.3-0ubuntu1~18.04.1 ADT test failure with B/5.4 kernels
+ (device_add_remove_test)
Revision history for this message
Guilherme G. Piccoli (gpiccoli) wrote :

Observed on B/aws-5.4 , cycle 20210621.

tags: added: 5.4 aws bionic sru-20210621
no longer affects: lxc
Revision history for this message
Guilherme G. Piccoli (gpiccoli) wrote :

Observed this on B/oracle-5.4, cycle sru-20210621 .

tags: added: oracle
Revision history for this message
Krzysztof Kozlowski (krzk) wrote :

Found on bionic/azure-5.4 5.4.0-1056.58~18.04.1 (and previous cycle 5.4.0-1054.56~18.04.1)

tags: added: azure sru-20210719
Revision history for this message
Tim Gardner (timg-tpi) wrote :

Observed on bionic:linux-aws-5.4 5.4.0-1055.58~18.04.1

Revision history for this message
Marcelo Cerri (mhcerri) wrote :

Observed on bionic:linux-azure-5.4 5.4.0-1056.58~18.04.1 .

Changed in lxc (Ubuntu):
status: Fix Released → In Progress
Po-Hsu Lin (cypressyew)
tags: added: sru-20210816
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Spotted on linux-gkeop-5.4/5.4.0-1024.25~18.04.1

tags: added: sru-20210906
Changed in lxc (Ubuntu):
status: In Progress → Fix Released
Changed in lxc (Ubuntu Bionic):
status: Confirmed → Triaged
Revision history for this message
Dimitri John Ledkov (xnox) wrote :
tags: added: sru-2023-01-30
Po-Hsu Lin (cypressyew)
tags: added: sru-20230130
removed: sru-2023-01-30
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

sponsored into unapproved queue

Changed in lxc (Ubuntu Bionic):
status: Triaged → In Progress
tags: added: sru-20230417
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Kleber, or anyone else affected,

Accepted lxc into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lxc/3.0.3-0ubuntu1~18.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in lxc (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
description: updated
description: updated
description: updated
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (lxc/3.0.3-0ubuntu1~18.04.3)

All autopkgtests for the newly accepted lxc (3.0.3-0ubuntu1~18.04.3) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

lxd/3.0.3-0ubuntu1~18.04.2 (i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#lxc

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

autopkgteest & general usage of lxc 3.0.3-0ubuntu1~18.04.3 works with host kernels on bionic's GA kernel and on hwe v5.4 kernels now.

verification done.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

cross test of lxd fails, but i386 is not supported under ESM and i'm not sure if i386 cross-arch autopkgtest is valid at all.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxc - 3.0.3-0ubuntu1~18.04.3

---------------
lxc (3.0.3-0ubuntu1~18.04.3) bionic; urgency=medium

  * Fix tests issue by avoiding falling back to inexistent trusty LXC images
    and using the bionic ones (LP: #1939537)

lxc (3.0.3-0ubuntu1~18.04.2) bionic; urgency=medium

  * Cherry-pick upstream bugfixes (LP: #1848587 LP: #1886790):
    - tests: use /dev/loop-control instead of /dev/network_latency
    - This unbreaks adt-matrix / adt testing of Bionic hwe kernels

 -- Andrei Gherzan <email address hidden> Fri, 05 May 2023 14:06:12 +0200

Changed in lxc (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for lxc has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.