Merge view options and settings into one single Settings action
Bug #1388807 reported by
David Planella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu File Manager App |
In Progress
|
Medium
|
David Planella | ||
Bug Description
Right now the settings for the app are scattered around two places:
- Settings action + page (which seems to be only shown on when running on the desktop)
- View action + popup
I'd propose to merge them into one and to use a page for consistency with the rest of the other core apps.
Related branches
lp://staging/~dpm/ubuntu-filemanager-app/merge-settings
- Jenkins Bot: Needs Fixing (continuous-integration)
- Arto Jalkanen: Needs Fixing
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 604 lines (+137/-367)5 files modifiedsrc/app/qml/filemanager.qml (+8/-29)
src/app/qml/ui/FolderListPage.qml (+6/-15)
src/app/qml/ui/PlacesPopover.qml (+0/-149)
src/app/qml/ui/SettingsPage.qml (+123/-19)
src/app/qml/ui/ViewPopover.qml (+0/-155)
| Changed in ubuntu-filemanager-app: | |
| status: | Triaged → In Progress |
Revision history for this message
| Arto Jalkanen (ajalkane) wrote | #1 |
To post a comment you must log in.
I'd also like to add that the current "Settings" page has only one setting, and as far as I know it has no effect at all. And is not even saved across application restarts. I'd say throw it away.