Security dialog causes tests to fail
Bug #1367453 reported by
Nicholas Skaggs
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu File Manager App |
Fix Released
|
Critical
|
Unassigned | ||
| Ubuntu Terminal App |
Fix Released
|
Critical
|
Unassigned | ||
Bug Description
The PAM authentication code included in terminal and file manager (https:/
These security requirements need to account for testability in order to be able to run tests on the applications in the following ways:
1) Test the app under security. Verify the dialog loads, can be authenticated into and the app is functional
2) Test the app under no security. Run the current set of tests.
For now, CI and these tests are broken on a phone running with security pin or password set.
Related branches
lp://staging/~ubuntu-filemanager-dev/ubuntu-filemanager-app/force-authentication-parameter
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Nicholas Skaggs (community): Needs Fixing
-
Diff: 2175 lines (+815/-710)10 files modifiedpo/com.ubuntu.filemanager.pot (+74/-52)
src/app/main.cpp (+22/-0)
src/app/qml/ui/FolderListPage.qml (+1/-1)
src/plugin/pamauthentication/pamauthentication.cpp (+0/-8)
tests/autopilot/filemanager/__init__.py (+539/-7)
tests/autopilot/filemanager/emulators.py (+0/-518)
tests/autopilot/filemanager/tests/__init__.py (+107/-53)
tests/autopilot/filemanager/tests/test_context_menu.py (+9/-10)
tests/autopilot/filemanager/tests/test_filemanager.py (+55/-53)
tests/autopilot/filemanager/tests/test_places.py (+8/-8)
lp://staging/~ubuntu-terminal-dev/ubuntu-terminal-app/fix-add-forceAuth
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Alan Pope 🍺🐧🐱 🦄: Pending requested
- Nicholas Skaggs: Pending requested
-
Diff: 139 lines (+81/-3)3 files modifiedsrc/app/main.cpp (+22/-0)
src/app/qml/AuthenticationService.qml (+1/-1)
tests/autopilot/ubuntu_terminal_app/tests/__init__.py (+58/-2)
lp://staging/~nskaggs/ubuntu-filemanager-app/fix-1367453
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Ubuntu File Manager Developers: Pending requested
-
Diff: 131 lines (+101/-6)1 file modifiedtests/autopilot/filemanager/tests/__init__.py (+101/-6)
| Changed in ubuntu-filemanager-app: | |
| status: | New → Confirmed |
| importance: | Undecided → Critical |
| Changed in ubuntu-terminal-app: | |
| status: | New → Confirmed |
| importance: | Undecided → Critical |
| description: | updated |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #1 |
| Changed in ubuntu-filemanager-app: | |
| status: | Confirmed → Fix Committed |
| Changed in ubuntu-terminal-app: | |
| status: | Confirmed → Triaged |
Revision history for this message
| Nicholas Skaggs (nskaggs) wrote | #2 |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #3 |
| Changed in ubuntu-terminal-app: | |
| status: | Triaged → Fix Released |
| Changed in ubuntu-filemanager-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-filemanager-app at revision 286, scheduled for release in ubuntu-