[SDK] Tap to hide toolbar is inconsistent
Bug #1453403 reported by
Sam Bull
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Document Viewer App |
Fix Released
|
High
|
Stefano Verzegnassi | ||
Ubuntu UX |
Fix Committed
|
Medium
|
Femma | ||
windows-binaries (Ubuntu) |
Invalid
|
Undecided
|
Unassigned |
Bug Description
Tap to show/hide toolbar is inconsistent with the rest of the OS. The usual approach for scrollable content is for the toolbar to slide up as you scroll down the page (that is, sliding the finger up the screen), with the toolbar coming back into view when scrolling the other way.
UX Resolution:
https:/
Related branches
lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/reboot-uitk13
- Roman Shchekin: Approve
- Jenkins Bot: Approve (continuous-integration)
-
Diff: 2460 lines (+798/-709)47 files modifieddebian/control (+1/-1)
po/com.ubuntu.docviewer.pot (+33/-76)
src/app/qml/common/CommandLineProxy.qml (+2/-2)
src/app/qml/common/DetailsPage.qml (+1/-1)
src/app/qml/common/EmptyState.qml (+2/-2)
src/app/qml/common/ErrorDialog.qml (+2/-2)
src/app/qml/common/HorizontalDivider.qml (+28/-0)
src/app/qml/common/PageWithBottomEdge.qml (+33/-43)
src/app/qml/common/PickImportedDialog.qml (+2/-2)
src/app/qml/common/RejectedImportDialog.qml (+2/-2)
src/app/qml/common/ResizeableSidebar.qml (+98/-0)
src/app/qml/common/SubtitledListItem.qml (+2/-2)
src/app/qml/common/TextFieldButtonPopover.qml (+58/-0)
src/app/qml/common/TextFieldWithButton.qml (+84/-0)
src/app/qml/common/UnknownTypeDialog.qml (+2/-2)
src/app/qml/common/VerticalDivider.qml (+35/-0)
src/app/qml/documentPage/DeleteFileDialog.qml (+2/-2)
src/app/qml/documentPage/DocumentDelegateActions.qml (+2/-2)
src/app/qml/documentPage/DocumentEmptyState.qml (+1/-1)
src/app/qml/documentPage/DocumentListDelegate.qml (+3/-3)
src/app/qml/documentPage/DocumentListView.qml (+1/-3)
src/app/qml/documentPage/DocumentPage.qml (+2/-2)
src/app/qml/documentPage/DocumentPageDefaultHeader.qml (+2/-2)
src/app/qml/documentPage/DocumentPagePickModeHeader.qml (+1/-1)
src/app/qml/documentPage/DocumentPageSearchHeader.qml (+1/-1)
src/app/qml/documentPage/DocumentPageSelectionModeHeader.qml (+2/-4)
src/app/qml/documentPage/SearchEmptyState.qml (+1/-1)
src/app/qml/documentPage/SectionHeader.qml (+2/-2)
src/app/qml/documentPage/SharePage.qml (+1/-1)
src/app/qml/documentPage/SortSettingsDialog.qml (+2/-2)
src/app/qml/loView/LOViewDefaultHeader.qml (+31/-30)
src/app/qml/loView/LOViewGotoDialog.qml (+2/-2)
src/app/qml/loView/LOViewPage.qml (+39/-95)
src/app/qml/loView/LOViewZoomHeader.qml (+0/-59)
src/app/qml/loView/PanelButton.qml (+1/-1)
src/app/qml/loView/PartsView.qml (+112/-58)
src/app/qml/loView/SlideControllerPanel.qml (+0/-87)
src/app/qml/loView/ZoomSelector.qml (+129/-114)
src/app/qml/pdfView/PdfContentsPage.qml (+3/-8)
src/app/qml/pdfView/PdfView.qml (+28/-19)
src/app/qml/pdfView/PdfViewDefaultHeader.qml (+5/-19)
src/app/qml/pdfView/PdfViewDelegate.qml (+1/-1)
src/app/qml/pdfView/PdfViewGotoDialog.qml (+2/-2)
src/app/qml/textView/TextView.qml (+3/-3)
src/app/qml/textView/TextViewDefaultHeader.qml (+5/-19)
src/app/qml/ubuntu-docviewer-app.qml (+14/-29)
src/plugin/libreofficetoolkit-qml-plugin/qml/Viewer.qml (+15/-1)
summary: |
- Tap to hide toolbar is inconsistent + [SDK] Tap to hide toolbar is inconsistent |
Changed in ubuntu-ux: | |
status: | New → Triaged |
importance: | Undecided → Medium |
assignee: | nobody → Olga Kemmet (olga-kemmet) |
Changed in ubuntu-ux: | |
assignee: | Olga Kemmet (olga-kemmet) → Femma (femma) |
description: | updated |
Changed in ubuntu-ux: | |
status: | Triaged → Won't Fix |
description: | updated |
Changed in ubuntu-ux: | |
status: | Won't Fix → Fix Committed |
Changed in windows-binaries (Ubuntu): | |
status: | New → Invalid |
Changed in ubuntu-docviewer-app: | |
status: | Confirmed → In Progress |
assignee: | nobody → Stefano Verzegnassi (verzegnassi-stefano) |
importance: | Undecided → High |
Changed in ubuntu-docviewer-app: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The current header behaviour is described in the app design guidelines[1] (see "Overlay" section), and it's used also in the image viewer of gallery-app[2].
"The Header is made semi-transparent and the content sits beneath it. Developers can choose for it to be displayed constantly or hidden on timeout or tap."
We have chosen this behaviour since the default one seems not to fit perfectly with our navigation pattern (in a standard list view, the elements provided are somehow in a hierarchy - e.g. relevance, date, etc - so scrolling up the view is a less important action than scrolling down, but pages in a PDF documents has not that strong hierarchy).
I agree that this behaviour is a bit weird, since it's not much used in Ubuntu SDK apps, but, being "authorized" by the UI guidelines, IMHO this is not a real issue.
Anyway we're missing the "semi-transparent" part, and this may require to be fixed.
I've heard some different opinion on the implementation of the header, before choosing the current one, so I'm open to any further discussion on this.
----- /design. ubuntu. com/apps/ building- blocks/ header# display- options bazaar. launchpad. net/~phablet- team/gallery- app/trunk/ view/head: /rc/qml/ MediaViewer/ MediaViewer. qml
[1]: https:/
[2]: line 166, http://