Use a C++ class to read content from plain text files
Bug #1398773 reported by
Stefano Verzegnassi
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Document Viewer App |
Triaged
|
Medium
|
Stefano Verzegnassi | ||
Bug Description
At the moment, our plain text reader use QML XMLHttpRequest to read the content of a file.
In file-qml-plugin we have a C++ class to do the same work, which would result in a cleaner and better code.
We should switch to use that C++ class as soon as possible, since we want to add some "advanced" features that are available in C++ Qt API only.
DESIRED SOLUTION:
Use FileReader class from file-qml-plugin, instead of XMLHttpRequest.
Also, we should provided the file content as QQuickTextDocum
Related branches
lp://staging/~verzegnassi-stefano/ubuntu-docviewer-app/advanced-text-editor
- Alan Pope 🍺🐧🐱 🦄 (community): Needs Fixing
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 1599 lines (+1309/-51)22 files modifieddebian/changelog (+6/-0)
debian/control (+1/-0)
manifest.json.in (+1/-1)
po/com.ubuntu.docviewer.pot (+82/-14)
src/app/qml/textView/TextView.qml (+37/-35)
src/app/qml/textView/TextViewDefaultHeader.qml (+21/-0)
src/app/qml/textView/TextViewSelectionHeader.qml (+81/-0)
src/app/qml/textView/TextViewSettingsPage.qml (+127/-0)
src/app/qml/ubuntu-docviewer-app.qml (+2/-0)
src/plugin/CMakeLists.txt (+1/-0)
src/plugin/text-qml-plugin/CMakeLists.txt (+38/-0)
src/plugin/text-qml-plugin/LineNumberColumn.qml (+66/-0)
src/plugin/text-qml-plugin/TextEditor.qml (+332/-0)
src/plugin/text-qml-plugin/TextEditorStyle.qml (+35/-0)
src/plugin/text-qml-plugin/backend.cpp (+37/-0)
src/plugin/text-qml-plugin/backend.h (+34/-0)
src/plugin/text-qml-plugin/documenthandler.cpp (+108/-0)
src/plugin/text-qml-plugin/documenthandler.h (+85/-0)
src/plugin/text-qml-plugin/filereader.cpp (+110/-0)
src/plugin/text-qml-plugin/filereader.h (+97/-0)
src/plugin/text-qml-plugin/qmldir (+7/-0)
tests/autopilot/ubuntu_docviewer_app/tests/test_docviewer.py (+1/-1)
| Changed in ubuntu-docviewer-app: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Stefano Verzegnassi (verzegnassi-stefano) |
| Changed in ubuntu-docviewer-app: | |
| status: | In Progress → Triaged |
| Changed in ubuntu-docviewer-app: | |
| assignee: | Stefano Verzegnassi (verzegnassi-stefano) → nobody |
| importance: | High → Medium |
| summary: |
- Use file-qml-plugin FileReader class, to read content from plain text - files + Use a C++ class to read content from plain text files |
| description: | updated |
| tags: | removed: bitesize |
| Changed in ubuntu-docviewer-app: | |
| milestone: | none → 2015-04-23 |
| Changed in ubuntu-docviewer-app: | |
| status: | Triaged → Won't Fix |
| status: | Won't Fix → In Progress |
| assignee: | nobody → Stefano Verzegnassi (verzegnassi-stefano) |
| Changed in ubuntu-docviewer-app: | |
| milestone: | 2015-04-23 → 2015-04-30 |
| Changed in ubuntu-docviewer-app: | |
| status: | In Progress → Triaged |
To post a comment you must log in.
