Ubuntu Clock App

Need a mechanism for specifying what happens when an ical menuitem is clicked

Bug #1426519 reported by Charles Kerr
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Ubuntu Calendar App
Fix Committed
Undecided
Kunal Parmar
Ubuntu Calendar App 2015-04-02 "Week 14"
Ubuntu Clock App
Triaged
Medium
Unassigned
Ubuntu Clock App 3.x.backlog "uncategorized"
indicator-datetime (Ubuntu)
Confirmed
Medium
Charles Kerr
Vivid
Confirmed
Undecided
Unassigned
qtorganizer5-eds (Ubuntu)
Fix Released
Undecided
Unassigned
Vivid
Confirmed
Undecided
Unassigned
reminders-app (Ubuntu)
Confirmed
Undecided
Unassigned

Bug Description

indicator-datetime needs a way to dispatch an arbitrary URL when a user clicks on an ical event menuitem.

In practice, datetime currently has clock-app hardwired for dispatching alarms (dispatch_url('appid://com.ubuntu.clock/clock/current-user-version')) and calendar-app for everything else (dispatch_url('appid://com.ubuntu.calendar/calendar/current-user-version')).

There are two use cases that can be supported by datetime handling the URL property <http://www.kanzaki.com/docs/ical/url.html>:

(1) Clicking on an alarm menuitem opens up clock-app to that specific alarm, rather than to clock-app's main page. Clock-app could specify the information it needs in the URL, then open the right page when passed that information later. indicator-datetime would act as a simple pass-through.

(2) non-calendar, non-alarm items such as from the reminders app as requested by mzanetti. The pattern would be the same as clock-app: Reminders would add whatever URL it wants, then datetime would act as a simple pass-through. This is preferable to adding more special cases to indicator-datetime.

See also related bug <https://bugs.launchpad.net/ubuntu/+source/indicator-datetime/+bug/1431384> which discusses abstracting out the icon shown in ical events' menuitems

See original description

Related branches

lp://staging/~renatofilho/qtorganizer5-eds/fix-1426519
Charles Kerr (community): Approve
PS Jenkins bot: Needs Fixing (continuous-integration)
Diff: 331 lines (+124/-16)
8 files modified
CMakeLists.txt (+1/-0)
organizer/qorganizer-eds-engine.cpp (+43/-7)
organizer/qorganizer-eds-engine.h (+3/-1)
organizer/qorganizer-eds-requestdata.cpp (+16/-4)
organizer/qorganizer-eds-requestdata.h (+1/-1)
tests/unittest/CMakeLists.txt (+0/-1)
tests/unittest/event-test.cpp (+59/-1)
tests/unittest/run-eds-test.sh (+1/-1)
lp://staging/~charlesk/indicator-datetime/lp-1426519-add-tag-for-menuitem-activation-url
Ted Gould (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 246 lines (+175/-5)
5 files modified
src/engine-eds.cpp (+24/-5)
tests/CMakeLists.txt (+1/-0)
tests/test-eds-tasks-config-files/.config/evolution/sources/system-proxy.source (+21/-0)
tests/test-eds-tasks-config-files/.local/share/evolution/tasks/system/tasks.ics (+28/-0)
tests/test-eds-tasks.cpp (+101/-0)
Ted Gould (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 246 lines (+175/-5)
5 files modified
src/engine-eds.cpp (+24/-5)
tests/CMakeLists.txt (+1/-0)
tests/test-eds-tasks-config-files/.config/evolution/sources/system-proxy.source (+21/-0)
tests/test-eds-tasks-config-files/.local/share/evolution/tasks/system/tasks.ics (+28/-0)
tests/test-eds-tasks.cpp (+101/-0)
lp://staging/~pkunal-parmar/ubuntu-calendar-app/UrlInvocation
Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
Bartosz Kosiorek (community): Approve
Mihir Soni: Pending requested
Diff: 62 lines (+33/-8)
1 file modified
calendar.qml (+33/-8)
lp://staging/ubuntu/wily/qtorganizer5-eds
Revision history for this message
Charles Kerr (charlesk) wrote :

Adding stakeholders to also-affects for feedback/comments

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

In the description, you mentioned that "Clock-app could specify the information it needs in the URL, then open the right page when passed that information later. indicator-datetime would act as a simple pass-through." Isn't it the other way around? The use case that I see is that when the user presses on an alarm shown in i-dt, i-dt then passes the necessary information that clock app requires to identify the alarm chosen by the user to open it.

I would still need to discuss with zsombor as to what information is required by the alarms API to open a specific alarm.

Charles Kerr (charlesk)
summary: - i-dt should support ical's "url" property for launching related apps
+ Need a mechanism for specifying what happens when an ical menuitem is
+ clickced
Revision history for this message
Charles Kerr (charlesk) wrote : Re: Need a mechanism for specifying what happens when an ical menuitem is clickced

nik90, what I mean is that the necessary information you're referring to would be encoded in the URL that is provided by clock-app (or by the alarm controls in ubuntu-ui-toollkit, depending on where that logic lives).

So I'd like to replace the current implentation ('url_dispatch("appid://com.ubuntu.calendar/calendar/current-user-version")') with something like 'url_dispatch(event.url)' where the url would be provided by clock/calendar/reminder and would read something like, say, 'appid://com.ubuntu.calendar/calendar/current-user-version?alarm=someAlarmId'

This would require clock-app (or the alarm controls) to add this code, but the advantage of this approach is it scales to future third-party apps as well as adding reminder to the current pool of clock & calendar.

description: updated
summary: Need a mechanism for specifying what happens when an ical menuitem is
- clickced
+ clicked
Changed in indicator-datetime (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in reminders-app (Ubuntu):
status: New → Confirmed
Changed in ubuntu-calendar-app (Ubuntu):
status: New → Confirmed
Alan Pope 🍺🐧🐱 🦄 (popey)
no longer affects: ubuntu-calendar-app (Ubuntu)
Changed in ubuntu-calendar-app:
milestone: none → 2015-04-02
assignee: nobody → Kunal Parmar (pkunal-parmar)
Kunal Parmar (pkunal-parmar)
Changed in ubuntu-calendar-app:
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package qtorganizer5-eds - 0.1.1+15.04.20150508.2-0ubuntu1

---------------
qtorganizer5-eds (0.1.1+15.04.20150508.2-0ubuntu1) vivid; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Renato Araujo Oliveira Filho ]
  * Added a new extra metadata property in collection (read-only
    property). (LP: #1347836)
  * Avoid filter or sort results if not necessary.
  * Implemented support for extended details. (LP: #1426519)
  * Optimize query by filtering collections related with the current
    query.
  * Removed missing debug.
  * Revert wrong commit.
  * Save a trigger for reminders with with secondsBeforeStart equals 0.
    (LP: #1440878)

 -- CI Train Bot <email address hidden> Fri, 08 May 2015 20:01:44 +0000

Changed in qtorganizer5-eds (Ubuntu):
status: New → Fix Released
Bartosz Kosiorek (gang65)
Changed in ubuntu-clock-app:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-calendar-app at revision 697, scheduled for release in ubuntu-calendar-app, milestone rtm14

Changed in ubuntu-calendar-app:
status: In Progress → Fix Committed
Bartosz Kosiorek (gang65)
Changed in ubuntu-clock-app:
milestone: none → 3.x.backlog
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in indicator-datetime (Ubuntu Vivid):
status: New → Confirmed
Changed in qtorganizer5-eds (Ubuntu Vivid):
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.