Branch source builder returns success for packages that fail to upload
Bug #1287882 reported by
Francis Ginther
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu CI Engine |
Fix Released
|
High
|
Francis Ginther | ||
| Ubuntu CI Services |
Fix Released
|
High
|
Francis Ginther | ||
Bug Description
The branch source builder uses a timeout to fail an upload. The timeout is working, but a successful result is returned. This should be an error with an appropriate message and build report.
Related branches
lp://staging/~fginther/ubuntu-ci-services-itself/bsbuilder-fixes
- Francis Ginther: Needs Fixing
-
Diff: 819 lines (+449/-97)11 files modifiedbranch-source-builder/bsbuilder/resources/v1.py (+2/-2)
branch-source-builder/bsbuilder/run_worker.py (+113/-30)
branch-source-builder/bsbuilder/tests/test_upload.py (+89/-0)
branch-source-builder/bsbuilder/tests/test_v1.py (+2/-2)
branch-source-builder/cupstream2distro/packageinppamanager.py (+4/-7)
branch-source-builder/setup.py (+4/-0)
branch-source-builder/upload_package.py (+47/-35)
branch-source-builder/watch_ppa.py (+163/-8)
juju-deployer/branch-source-builder.yaml.tmpl (+1/-1)
lander/bin/lander_service_wrapper.py (+12/-12)
lander/bin/ticket_api.py (+12/-0)
lp://staging/~doanac/ubuntu-ci-services-itself/bsbuilder-better-error-handling
- Francis Ginther: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 470 lines (+273/-40)5 files modifiedbranch-source-builder/bsbuilder/run_worker.py (+103/-23)
branch-source-builder/cupstream2distro/packageinppamanager.py (+4/-7)
branch-source-builder/setup.py (+2/-1)
branch-source-builder/watch_ppa.py (+163/-8)
juju-deployer/branch-source-builder.yaml.tmpl (+1/-1)
| Changed in ubuntu-ci-services-itself: | |
| status: | Confirmed → In Progress |
| Changed in ubuntu-ci-services-itself: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-ci-services-itself: | |
| status: | Fix Committed → Fix Released |
| Changed in uci-engine: | |
| assignee: | nobody → Francis Ginther (fginther) |
| importance: | Undecided → High |
| milestone: | none → phase-0 |
| status: | New → Fix Released |
To post a comment you must log in.
