Reduce duplicate code in PortraitKeyboard.qml and LandscapeKeyboard.qml

Bug #1522162 reported by Niklas Wenzel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Calculator App
New
Undecided
Unassigned

Bug Description

The files PortraitKeyboard.qml and LandscapeKeyboard.qml contain a lot of duplicate code.

Changing these files is sometimes required when adding new features/fixing bugs and one can easily forget to modify both files. So I'd propose moving the key definitions to another file (where possible) and sharing them between the two *Keyboard.qml files.

Furthermore, we have the color definition "#DD4814" in there quite often, so that should be moved to a separate property as well, which should then be accessed by all key definitions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.