Accomplishments Viewer should use GtkInfoBar for displaying notifications

Bug #981786 reported by Rafał Cieślak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Accomplishments Viewer
Fix Committed
Wishlist
Rafał Cieślak

Bug Description

Accomplishments Viewer should use GtkInfoBar for displaying notifications, which is the right way of displaying questions & warnings to the user without a dialog-box, instead if currently used expanded widgets. Not only it looks much better , but also is much more consistent with other gtk applications.

Related branches

Revision history for this message
Jono Bacon (jonobacon) wrote :

I agree this would look more consistent. Can we show other widgets though (e.g. buttons) so we could replace all the views other than the Edit Information view?

Changed in ubuntu-accomplishments-viewer:
status: New → Incomplete
Revision history for this message
Jono Bacon (jonobacon) wrote :

Oh, and I recommend we don't put this on the 0.1 list; we can fix this in 0.2. :-)

Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

Any other widget may be added into GtkInfoBar, though it defaults to a label (header + detailed text) and a set of buttons, which satisfies our needs. And I do agree to postpone it to 0.2, enough changes for 0.1 :-)

Revision history for this message
Jono Bacon (jonobacon) wrote : Re: [Bug 981786] Re: Accomplishments Viewer should use GtkInfoBar for displaying notifications

On 15 April 2012 02:02, Rafal Cieślak <email address hidden> wrote:
> Any other widget may be added into GtkInfoBar, though it defaults to a
> label (header + detailed text) and a set of buttons, which satisfies our
> needs. And I do agree to postpone it to 0.2, enough changes for 0.1 :-)

Sounds good. Let's review this again when we have 0.1 out the door.

--
Jono Bacon
Ubuntu Community Manager
www.ubuntu.com / www.jonobacon.org
www.identi.ca/jonobacon www.twitter.com/jonobacon

Revision history for this message
Jono Bacon (jonobacon) wrote :

Now we are building up towards 0.3, I think it would be a good time to revisit this topic. I am not assigning this as a milestone bug for 0.3 as I think we can still consider this non-essential.

Importantly, we need to ensure that the GtkInfo bar can embed within itself the widgets that we use - our various notifications include buttons, labels, and other widgets.

Changed in ubuntu-accomplishments-viewer:
status: Incomplete → Confirmed
Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

We have been postponing this since 0.1, I have assigned this to 0.4 to make sure we finally implement this.

I confirm a GtkInfoBar can embed anything, literally any other widget or container, thus it's suitable for our needs.
I have linked a branch that contains my solution to this bug, and we'll merge it once a review will confirm that this design is fine.

Changed in ubuntu-accomplishments-viewer:
assignee: nobody → Rafal Cieślak (rafalcieslak256)
status: Confirmed → In Progress
milestone: none → 0.4
Changed in ubuntu-accomplishments-viewer:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.