Ubuntu Accomplishments Viewer

viewer using deprecated interface: invalidate_extra_information()

Bug #1036468 reported by Matt Fischer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Accomplishments Viewer
Fix Committed
Low
Rafał Cieślak
Ubuntu Accomplishments Viewer 0.4

Bug Description

invalidate_extra_information() is marked as deprecated in the Daemon API, but the viewer is still using it. If it's truly deprecated then lets stop using it and remove it before 0.3 goes out. I filed this as one bug here, but the change will be in the viewer and daemon

Revision history for this message
Jono Bacon (jonobacon) wrote :

I don't recall why we deprecated it. Does anyone else?

Changed in ubuntu-accomplishments-viewer:
status: New → Incomplete
Revision history for this message
Matt Fischer (mfisch) wrote :

Rafael made this change with rev 101, so I'm assigning this to him, he'll know why it was marked deprecated.

101 rafalci | .. warning::
                          | This function is deprecated.

------------------------------------------------------------
revno: 101
committer: Rafał Cieślak <email address hidden>
branch nick: ubuntu-accomplishments-daemon
timestamp: Fri 2012-07-13 19:32:38 +0200
message:
   * Documenting five more functions
-----------------------------------------------------

Revision history for this message
Matt Fischer (mfisch) wrote :

For some reason I cannot assign this to Rafal, Jono can you do it?

Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

In 0.1 this function was meant to remove all .trophy files and their signatures that used an outdated extra-information when the user has changed the credentials he uses. For 0.2 we decided we'll *never* remove any .trophy files, and therefore the body of this function is gone. The function itself (and reference to it in the viewer) is still present, because we suspected we may want to use it in some other way, e.g. setting a flag inside the .trophy file, or something else. Since we don't do this, I guess we're free to get rid of it.

Matt Fischer (mfisch)
Changed in ubuntu-accomplishments-viewer:
status: Incomplete → Confirmed
Rafał Cieślak (rafalcieslak256)
Changed in ubuntu-accomplishments-viewer:
assignee: nobody → Rafal Cieślak (rafalcieslak256)
status: Confirmed → Fix Committed
milestone: none → 0.4
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.