AMQClient.close doesn't shutdown the AMQP connection cleanly
Bug #1589988 reported by
Free Ekanayaka
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| txAMQP |
Fix Committed
|
Undecided
|
Free Ekanayaka | ||
Bug Description
The AMQP specification formally requires to perform a close/close-ok handshake before shutting down the transport socket:
"A peer that detects a socket closure without having received a Close-Ok handshake method SHOULD log the error."
(see https:/
I've seen that most other AMQP clients do that, it'd be nice for txamqp to do it too.
Related branches
lp://staging/~free.ekanayaka/txamqp/closing-logic-cleanup
- Adam Collard (community): Approve
- Alberto Donato (community): Approve
- txAMQP Team: Pending requested
-
Diff: 304 lines (+183/-7)6 files modifiedsrc/txamqp/client.py (+6/-1)
src/txamqp/protocol.py (+50/-5)
src/txamqp/test/test_broker.py (+9/-0)
src/txamqp/test/test_endpoint.py (+1/-1)
src/txamqp/test/test_protocol.py (+113/-0)
src/txamqp/testing.py (+4/-0)
| Changed in txamqp: | |
| status: | New → In Progress |
| assignee: | nobody → Free Ekanayaka (free.ekanayaka) |
| Changed in txamqp: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
