automatically build review tickets

Bug #352128 reported by Glyph Lefkowitz
2
Affects Status Importance Assigned to Milestone
Twisted Buildbot Configuration
New
Undecided
Unassigned
Twisted/Trac Integration
Confirmed
Medium
Unassigned

Bug Description

When a ticket that contains a server-side branch (i.e. not a patch, for obvious security reasons) is submitted for review in trac, something (a trac plugin?) should automatically kick off a build for that branch for all supported builders.

Changed in twisted-trac-integration:
assignee: nobody → exarkun
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Jean-Paul Calderone (exarkun) wrote :

... and do so in a way that doesn't knock over buildbot (ie, don't submit new builds while existing builds are running or for a short period of time after they complete - or, fix buildbot to not die when this happens).

Changed in twisted-trac-integration:
assignee: Jean-Paul Calderone (exarkun) → nobody
Revision history for this message
Tom Prince (tom.prince) wrote :

I'll procede on the assumption that buildbot can be fixed not fall over. (BTW, if you have an example of that happening post-0.8.6, can you file a bug with a pointer to where that happens, so I can diagnose and fix it).

Revision history for this message
Tom Prince (tom.prince) wrote :

From #352126 (about force-build.py)
  * automatically submitting the ticket for review if the builds complete successfully

I'm not sure how these two things should interact? Presumably both are useful, but would potentially trigger duplicate builds. Perhaps there should be a different keyword to trigger the build, and afterwards put it into review?

Revision history for this message
Glyph Lefkowitz (glyph) wrote :

How about let's implement submit-for-review in force-builds.py first? That's more explicit, and it would be really nice to have force-builds tell me when the build is done, too. We can resolve the potential conflict later.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.