Displays the hook name rather than the .desktop Name
Bug #1504022 reported by
Sebastien Bacher
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Thomas Voß | ||
| trust-store |
In Progress
|
High
|
Thomas Voß | ||
Bug Description
Using current rc-proposed image on bq
Try to use the camera from the "authentificator" store application, you get a trust store prompt asking if you want to let "ubuntu-sso" access to CameraService
"ubuntu-sso" is the name of the click hook, it's neither user friendly nor translatable, instead the prompt should display the Name from the .desktop included in the click
<https:/
Related branches
lp://staging/~thomas-voss/trust-store/fix-1504022
- Matthew Paul Thomas (community): Approve (design)
- Tyler Hicks: Approve
- Alberto Mardegan (community): Approve
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 1270 lines (+687/-167)17 files modifiedCMakeLists.txt (+1/-1)
debian/control (+1/-0)
po/trust-store.pot (+10/-11)
src/CMakeLists.txt (+7/-0)
src/core/trust/daemon.cpp (+1/-1)
src/core/trust/mir/agent.cpp (+22/-42)
src/core/trust/mir/agent.h (+44/-16)
src/core/trust/mir/click_desktop_entry_app_info_resolver.cpp (+139/-0)
src/core/trust/mir/click_desktop_entry_app_info_resolver.h (+49/-0)
src/core/trust/mir/prompt_main.cpp (+44/-41)
src/core/trust/mir/prompt_main.h (+16/-4)
src/core/trust/mir/prompt_main.qml (+66/-30)
tests/CMakeLists.txt (+20/-0)
tests/click_desktop_entry_app_name_resolver_test.cpp (+75/-0)
tests/mir_agent_test.cpp (+131/-21)
tests/share/applications/valid.pkg_app_0.0.0.desktop (+56/-0)
tests/test_data.h.in (+5/-0)
- Alberto Mardegan (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 772 lines (+451/-71)12 files modifiedCMakeLists.txt (+1/-1)
debian/control (+1/-0)
src/CMakeLists.txt (+7/-0)
src/core/trust/mir/agent.cpp (+11/-38)
src/core/trust/mir/agent.h (+29/-14)
src/core/trust/mir/click_desktop_entry_app_name_resolver.cpp (+106/-0)
src/core/trust/mir/click_desktop_entry_app_name_resolver.h (+49/-0)
tests/CMakeLists.txt (+20/-0)
tests/click_desktop_entry_app_name_resolver_test.cpp (+60/-0)
tests/mir_agent_test.cpp (+107/-18)
tests/share/applications/valid.pkg_app_0.0.0.desktop (+55/-0)
tests/test_data.h.in (+5/-0)
- Ubuntu Phablet Team: Pending requested
-
Diff: 1514 lines (+613/-303)33 files modifiedCMakeLists.txt (+3/-2)
debian/changelog (+16/-0)
debian/control (+8/-11)
debian/libtrust-store1.install (+0/-2)
debian/libtrust-store1.symbols (+0/-162)
debian/libtrust-store2.install (+2/-0)
debian/rules (+7/-5)
debian/source/format (+1/-1)
debian/trust-store-bin.install (+0/-2)
debian/trust-store-bin.install.with_mir (+4/-0)
po/ast.po (+5/-5)
po/ca.po (+4/-4)
po/de.po (+5/-5)
po/el.po (+5/-5)
po/en_AU.po (+4/-4)
po/es.po (+4/-4)
po/gd.po (+4/-4)
po/it.po (+5/-5)
po/pl.po (+5/-5)
po/ro.po (+5/-5)
src/CMakeLists.txt (+11/-0)
src/core/trust/daemon.cpp (+1/-1)
src/core/trust/mir/agent.cpp (+12/-39)
src/core/trust/mir/agent.h (+29/-14)
src/core/trust/mir/click_desktop_entry_app_name_resolver.cpp (+122/-0)
src/core/trust/mir/click_desktop_entry_app_name_resolver.h (+54/-0)
src/core/trust/mir/prompt_main.cpp (+2/-0)
tests/CMakeLists.txt (+20/-0)
tests/click_db_for_testing/valid.alt.pkg/0.0.0/app.desktop (+55/-0)
tests/click_db_for_testing/valid.pkg/0.0.0/share/applications/app.desktop (+55/-0)
tests/click_desktop_entry_app_name_resolver.cpp (+53/-0)
tests/mir_agent_test.cpp (+107/-18)
tests/test_data.h.in (+5/-0)
Revision history for this message
| Thomas Voß (thomas-voss) wrote | #1 |
| Changed in trust-store: | |
| importance: | Undecided → High |
| assignee: | nobody → Thomas Voß (thomas-voss) |
| status: | New → Triaged |
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Thomas Voß (thomas-voss) |
| importance: | Undecided → High |
| milestone: | none → backlog |
| status: | New → Confirmed |
| Changed in trust-store: | |
| status: | Triaged → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → In Progress |
| milestone: | backlog → ww02-2016 |
| description: | updated |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This issue touches on an underlying problem: Right now, we do not integrate with the platform's database of installed packages for resolving an AppArmor profile name to something trasnlateable and meaningful in the general case.