Pass optional timeout to service commands
Bug #1556314 reported by
Petr Malik
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack DBaaS (Trove) |
Fix Released
|
Low
|
Unassigned | ||
| Mitaka |
Fix Committed
|
Low
|
Unassigned | ||
| Newton |
Fix Released
|
Low
|
Petr Malik | ||
Bug Description
Pass optional timeout to service commands
Service commands may take some time to return.
The current code does not pass any timeout value into the execute
function resulting in the default 30s value being used.
That value turns out to be too short for certain datastores
(Cassandra) on slower/
Trove already has a timeout (default=3min) for instance state changes that
should be used instead (this timeout has already been used when
polling for database states).
The service command execute function have been updated to accept an
optional timeout kwargs (like the shell command execute function).
The state change timeout is now being passed in from DB
start/stop/restart calls.
| Changed in trove: | |
| milestone: | none → newton-1 |
| status: | New → In Progress |
| Changed in trove: | |
| assignee: | Petr Malik (pmalik) → Amrith (amrith) |
| no longer affects: | trove/newton |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to trove (master) | #1 |
| Changed in trove: | |
| status: | In Progress → Fix Released |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix proposed to trove (stable/mitaka) | #2 |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Fix merged to trove (stable/mitaka) | #3 |
Revision history for this message
| Doug Hellmann (doug-hellmann) wrote Fix included in openstack/trove 5.0.1 | #4 |
Revision history for this message
| Doug Hellmann (doug-hellmann) wrote Fix included in openstack/trove 6.0.0.0b2 | #5 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 87658dc4cc59f7c
Author: Petr Malik <email address hidden>
Date: Thu Mar 10 22:41:59 2016 -0500
Pass optional timeout to service commands
Service commands may take some time to return.
The current code does not pass any timeout value into the execute
function resulting in the default 30s value being used.
That value turns out to be too short for certain datastores
(Cassandra) on slower/
Trove already has a timeout (default=3min) for instance state changes that
should be used instead (this timeout has already been used when
polling for database states).
The service command execute function have been updated to accept an
optional timeout kwargs (like the shell command execute function).
The state change timeout is now being passed in from DB
start/
Change-Id: I1ef45b95d9238a
Closes-Bug: 1556314