tripleo

Generating fencing from capitalized MAC returns nothing

  1. Series rocky
  2. Bug #1800504
Bug #1800504 reported by David Vallee Delisle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Undecided
Michele Baldessari
Queens
Fix Committed
Undecided
Michele Baldessari
Rocky
Fix Committed
Undecided
Michele Baldessari
Stein
Fix Released
Undecided
Michele Baldessari

Bug Description

Description
===========
When deploying using instackenv.json with capitalized MAC, the ports are created with lower case. When we later generate fencing, nothing is returned

Steps to reproduce
==================
* Use capitalized MACs in instackenv.json
* Deploy environment
* openstack overcloud generate fencing --ipmi-lanplus --ipmi-level administrator --output fencing.yaml instackenv.json

Expected result
===============
We should have a populated fencing.yaml file

Actual result
=============
File is empty.

This is the port list after deployment:
+--------------------------------------+-------------------+
| UUID | Address |
+--------------------------------------+-------------------+
| dd295dab-c162-496f-ac67-da8e53587237 | f4:e9:d4:72:a7:2e |
| 0ae89236-e5b4-40bd-bc19-9cb4e7a224b5 | f4:e9:d4:72:a9:14 |
| 839443dd-6d54-4336-a751-8839294349a8 | f4:e9:d4:ed:fa:32 |
| 49bbe677-b958-4d1c-bfc0-49152eff4dcd | f4:e9:d4:ed:f9:90 |
| 5225e0fd-b37d-4dff-91f7-4817f724f10d | f4:e9:d4:72:a9:b6 |
+--------------------------------------+-------------------+

Environment
===========
1. Exact version of OpenStack you are running.

Queens

David Vallee Delisle (valleedelisle)
Changed in tripleo:
assignee: nobody → David Vallee Delisle (valleedelisle)
OpenStack Infra (hudson-openstack)
Changed in tripleo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/614498

Changed in tripleo:
assignee: David Vallee Delisle (valleedelisle) → Chris Jones (cmsj)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-common (master)

Change abandoned by Chris Jones (<email address hidden>) on branch: master
Review: https://review.openstack.org/614498
Reason: dvd already posted https://review.openstack.org/#/c/613990

Revision history for this message
Chris Jones (cmsj) wrote :

Apologies dvd, I missed that you'd already posted a patch at https://review.openstack.org/#/c/613990

Revision history for this message
David Vallee Delisle (valleedelisle) wrote :

Thanks for the contribution Chris!

OpenStack Infra (hudson-openstack)
Changed in tripleo:
assignee: David Vallee Delisle (valleedelisle) → Michele Baldessari (michele)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/613990
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=84603a06af326fbc4ca09fa7c28d9a44a80f1f42
Submitter: Zuul
Branch: master

commit 84603a06af326fbc4ca09fa7c28d9a44a80f1f42
Author: David Vallee Delisle <email address hidden>
Date: Mon Oct 29 12:53:57 2018 -0400

    Generating fencing for capitalized MACs

    Because the ports are stored in lower case, we need to use lower case
    MACs as our search key.

    Change-Id: I7e3727987265ef5222c95678c69cc4a50176dd16
    Closes-Bug: #1800504

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/619725

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/rocky)

Reviewed: https://review.openstack.org/619725
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7d609f111ad18c47cb84552826ca13ee60f83f35
Submitter: Zuul
Branch: stable/rocky

commit 7d609f111ad18c47cb84552826ca13ee60f83f35
Author: David Vallee Delisle <email address hidden>
Date: Mon Oct 29 12:53:57 2018 -0400

    Generating fencing for capitalized MACs

    Because the ports are stored in lower case, we need to use lower case
    MACs as our search key.

    Change-Id: I7e3727987265ef5222c95678c69cc4a50176dd16
    Closes-Bug: #1800504
    (cherry picked from commit 84603a06af326fbc4ca09fa7c28d9a44a80f1f42)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/625203

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/queens)

Reviewed: https://review.openstack.org/625203
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=5f93512ba90d68dc28d8c41b0052ff311b95c8a7
Submitter: Zuul
Branch: stable/queens

commit 5f93512ba90d68dc28d8c41b0052ff311b95c8a7
Author: David Vallee Delisle <email address hidden>
Date: Mon Oct 29 12:53:57 2018 -0400

    Generating fencing for capitalized MACs

    Because the ports are stored in lower case, we need to use lower case
    MACs as our search key.

    NB: cherry-pick is not entirely clean because we do not want to backport
    I74d4178dbb0cfe8c934ce15e3e7c9bb1c469de10
    (enrich-ironic-networking-integration) to queens

    Change-Id: I7e3727987265ef5222c95678c69cc4a50176dd16
    Closes-Bug: #1800504
    (cherry picked from commit 84603a06af326fbc4ca09fa7c28d9a44a80f1f42)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 10.2.0

This issue was fixed in the openstack/tripleo-common 10.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 8.6.7

This issue was fixed in the openstack/tripleo-common 8.6.7 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 9.5.0

This issue was fixed in the openstack/tripleo-common 9.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.