[CI] tox-ansible-test-sanity doesn't take the "ignore" anymore

Bug #1976251 reported by Cédric Jeanneret
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Unassigned

Bug Description

At least in ansible-role-collect-logs project, it seems the ansible-test doesn't take the tests/sanity/*.txt into account, leading to false flags, preventing merging patches.

The content of the file is correct, according to the doc[1]:
plugins/modules/ara_graphite.py validate-modules:missing-gplv3-license
plugins/modules/ara_influxdb.py validate-modules:missing-gplv3-license
plugins/modules/flatten_nested_dict.py validate-modules:missing-gplv3-license
plugins/modules/sova.py validate-modules:missing-gplv3-license
plugins/modules/sova.py pylint:use-a-generator

But in the end, those actually ignored failures are blocking merges, for instance here:
https://zuul.opendev.org/t/openstack/build/5b8079b1b7474b938d54000376d2b124

Not sure what to do at this point :/.

[1] https://docs.ansible.com/ansible/latest/dev_guide/testing/sanity/ignores.html

Tags: alert ci
Revision history for this message
Cédric Jeanneret (cjeanner) wrote :

Wondering how this is possible:
sanity installed: ansible-core==2.13.0,cffi==1.15.0,cryptography==37.0.2,Jinja2==3.1.2,MarkupSafe==2.1.1,packaging==21.3,pycparser==2.21,pyparsing==3.0.9,PyYAML==6.0,resolvelib==0.5.4

according to the requirements, we're supposed to get:
ansible-core>=2.11,<2.12

How comes we're with core==2.13 ?!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-role-collect-logs (master)
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-role-collect-logs (master)

Reviewed: https://review.opendev.org/c/openstack/ansible-role-collect-logs/+/843848
Committed: https://opendev.org/openstack/ansible-role-collect-logs/commit/5f1069ba9aacf207c94d89d97b43d36985e9e908
Submitter: "Zuul (22348)"
Branch: master

commit 5f1069ba9aacf207c94d89d97b43d36985e9e908
Author: Cédric Jeanneret <email address hidden>
Date: Mon May 30 14:12:27 2022 +0200

    Some linting, and correcting deps for sanity

    ansible-test seems to take the latest ansible-core by default, even if
    we push upper/lower constraints in the requirements.txt or
    test-requirements.txt.

    Pushing the constraint directly in the tox.ini, for the "sanity"
    testenv, seems to do the trick, as we're testing against an ansible
    version we actually support, instead of the latest (2.13 today).

    This patch also takes the opportunity to remove unwanted warnings
    (ansible.cfg deprecated options), as well as ensuring the ignored
    content for `ansible-test' doesn't raise any warning.

    Closes-Bug: #1976251
    Change-Id: I596aecd71ebe7d8a747ab8e6d05766f70dd78f1d

Changed in tripleo:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.