tripleo

openstack-tox-pep8 is failing on tripleo-heat-templates master jobs - deploy_source_host variable is not defined

Bug #1964935 reported by Ronelle Landy on 2022-03-15

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Critical	James Slagle	tripleo yoga-3

Bug Description

openstack-tox-pep8 jobs are failing on tripleo-heat-templates master branch reviews with the following error:

2022-03-15 10:25:27.881986 | ubuntu-focal | fqcn-builtins: Use FQCN for builtin actions.
2022-03-15 10:25:27.882022 | ubuntu-focal | common/deploy-steps-playbooks-common.yaml:11 Task/Handler: fail msg=deploy_source_host variable is not defined
2022-03-15 10:25:27.882030 | ubuntu-focal |
2022-03-15 10:25:27.882554 | ubuntu-focal | fqcn-builtins: Use FQCN for builtin actions.
2022-03-15 10:25:27.882578 | ubuntu-focal | common/deploy-steps-playbooks-common.yaml:14 Task/Handler: fail msg=deploy_target_host variable is not defined

....

2022-03-15 11:25:47.072054 | ubuntu-focal | Finished with 8 failure(s), 2 warning(s) on 1774 files.
2022-03-15 11:25:47.215704 | ubuntu-focal | ERROR: InvocationError for command /home/zuul/src/opendev.org/openstack/tripleo-heat-templates/.tox/pep8/bin/ansible-lint -v (exited with code 2)
2022-03-15 11:25:47.215773 | ubuntu-focal | pep8 finish: run-test after 160.01 seconds
2022-03-15 11:25:47.359303 | ubuntu-focal | pep8 start: run-test-post
2022-03-15 11:25:47.359384 | ubuntu-focal | pep8 finish: run-test-post after 0.00 seconds
2022-03-15 11:25:47.359406 | ubuntu-focal | ___________________________________ summary ____________________________________
2022-03-15 11:25:47.359425 | ubuntu-focal | ERROR: pep8: commands failed
2022-03-15 11:25:47.390216 | ubuntu-focal | .tox finish: provision after 163.23 seconds

A full log is below:

https://2830f36aa7d2d3d5c6b4-034c6bc4778c3cc144ccaa5955a4efef.ssl.cf1.rackcdn.com/833285/3/check/openstack-tox-pep8/be0063b/job-output.txt

The failures started on 03/15:

https://zuul.opendev.org/t/openstack/builds?job_name=openstack-tox-pep8&project=openstack%2Ftripleo-heat-templates&branch=master&skip=0

Tags:

Ronelle Landy (rlandy) on 2022-03-15

Changed in tripleo:
milestone:	none → yoga-3
importance:	Undecided → Critical
status:	New → Triaged
tags:	added: promotion-blocker
summary:	- openstack-tox-pep8 is failin on tripleo-heat-templates master jobs - + openstack-tox-pep8 is failing on tripleo-heat-templates master jobs - deploy_source_host variable is not defined

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-03-15: Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/833776

Changed in tripleo:
status:	Triaged → In Progress

James Slagle (james-slagle) on 2022-03-15

Changed in tripleo:
assignee:	nobody → James Slagle (james-slagle)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-03-15: Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/833776
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/de668b4ec21cd022d4452b107e8c16b9b82b7d32
Submitter: "Zuul (22348)"
Branch: master

commit de668b4ec21cd022d4452b107e8c16b9b82b7d32
Author: James Slagle <email address hidden>
Date: Tue Mar 15 08:10:17 2022 -0400

Use FQCN for ansible builtin tasks

Using the FQCN for ansible builtin tasks is required by the new
ansible-lint 6.0.0. Otherwise, the pep8 job fails running ansible-lint.

Closes-Bug: #1964935

Change-Id: I82f65a39856bc86cbdb58de969f0392ea36c4e04
Signed-off-by: James Slagle <email address hidden>

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

Marios Andreou (marios-b) wrote on 2022-03-16:

also failing on wallaby there

https://zuul.opendev.org/t/openstack/build/8d72ffafb4b3441783d9a2bdd3936077

fqcn-builtins: Use FQCN for builtin actions.
common/deploy-steps-playbooks-common.yaml:14 Task/Handler: fail msg=deploy_target_host variable is not defined

do we need that patch on wallaby then as well looks like?

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-03-16: Fix proposed to tripleo-heat-templates (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/834012

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2022-03-17: Fix merged to tripleo-heat-templates (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/834012
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/524d8a88725bec04265078f42b48181c95ea0de1
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 524d8a88725bec04265078f42b48181c95ea0de1
Author: James Slagle <email address hidden>
Date: Tue Mar 15 08:10:17 2022 -0400

Use FQCN for ansible builtin tasks

Using the FQCN for ansible builtin tasks is required by the new
ansible-lint 6.0.0. Otherwise, the pep8 job fails running ansible-lint.

Closes-Bug: #1964935

    Change-Id: I82f65a39856bc86cbdb58de969f0392ea36c4e04
    Signed-off-by: James Slagle <email address hidden>
    (cherry picked from commit de668b4ec21cd022d4452b107e8c16b9b82b7d32)