Ansible multi nic templates broke the nicX relation to network order in network_data.yaml

Bug #1904894 reported by Harald Jensås
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Harald Jensås

Bug Description

With the Heat multi-nic example templates the loop.index was used to set the nicX.
With Heat the iteration was on all networks in 'network_data.yaml', so you would end up with:

Given network data:
 - name: External
 - name: InternalApi
 - name: Storage
 - name: StorageMgmt
 - name: Tenant

For a Controller with networks ctlplane, External, InternalApi, Storage, StorageMgmt, Tenant the nicX in the generated template would be:

    ctlplane: nic1
    External: nic2
    InternalApi: nic3
    Storage: nic4
    StorageMgmt: nic5
    Tenant: nic6

For a compute with networks ctlplane, external_bridge, InternalApi, Storage, Tenant the nicX in the generated template would be:

   ctlplane: nic1
   external_bridge: nic2
   InternalApi: nic3
   Storage: nic4
   Tenant: nic6

With the ansible templates the j2 is iterating over role networks only _and_ the External network is always put last in the DVR multi_nic templates. So we end up with:

For Controllers:
    ctlplane: nic1
    InternalApi: nic2
    Storage: nic3
    StorageMgmt: nic4
    Tenant: nic5
    External: nic6

For Compute:
   ctlplane: nic1
   InternalApi: nic2
   Storage: nic3
   Tenant: nic4
   external_bridge: nic5

The result is that anyone using environments/net-multiple-nics.yaml out of the box will have to re-wire the physical cabling in the datacenter.

The same is true for users of environments/net-multiple-nics-vlans.yaml

summary: - Ansible multi nic templates broke the nicX and network order in
+ Ansible multi nic templates broke the nicX relation to network order in
network_data.yaml
tags: added: upgrade
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/763496

Changed in tripleo:
assignee: nobody → Harald Jensås (harald-jensas)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/763497

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-quickstart (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/763500

Changed in tripleo:
importance: Medium → High
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 3.0.0

This issue was fixed in the openstack/tripleo-ansible 3.0.0 release.

Changed in tripleo:
milestone: wallaby-2 → wallaby-3
Changed in tripleo:
milestone: wallaby-3 → wallaby-rc1
Changed in tripleo:
milestone: wallaby-rc1 → xena-1
Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-quickstart (master)

Change abandoned by "Harald Jensås <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart/+/763500
Reason: See review comments on https://review.opendev.org/c/openstack/tripleo-quickstart/+/800173

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.