tripleo

[train-only] waiting for ssh to come up during deployment spits ResourceWarnings

Bug #1888676 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
In Progress
Medium
Alex Schultz
tripleo xena-3

Bug Description

The related code was removed in Ussuri, but train throws resource warnings during the deployment when waiting for the nodes to become available.

/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:181: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('0.0.0.0', 38280)>
  sock = socket.socket(socket.AF_INET6)
/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:175: ResourceWarning: unclosed <socket.socket fd=9, family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0, laddr=('::', 0, 0, 0)>
  sock = socket.socket()
/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:181: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('0.0.0.0', 38598)>
  sock = socket.socket(socket.AF_INET6)
/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:181: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('0.0.0.0', 38688)>
  sock = socket.socket(socket.AF_INET6)
/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:181: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('0.0.0.0', 38736)>
  sock = socket.socket(socket.AF_INET6)
/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:181: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('0.0.0.0', 38780)>
  sock = socket.socket(socket.AF_INET6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/742678

Alex Schultz (alex-schultz)
Changed in tripleo:
importance: Undecided → Medium
status: New → In Progress
Emilien Macchi (emilienm)
Changed in tripleo:
milestone: victoria-2 → victoria-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/train)

Reviewed: https://review.opendev.org/742678
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=9e08f1ead2988d1bbb54e193bdd7dfd6118b68f3
Submitter: Zuul
Branch: stable/train

commit 9e08f1ead2988d1bbb54e193bdd7dfd6118b68f3
Author: Alex Schultz <email address hidden>
Date: Thu Jul 23 08:04:42 2020 -0600

    [TRAIN-and-older] Properly close sockets

    Currently we properly close the ipv4 socket when we're check for nodes
    to become available. This change adds additional closes to ensure we
    clean up the sockets when we're done with them while we wait.

    Note this code was removed in Ussuri so this is a <= train only patch

    Change-Id: Ie1711972e2fdb2af80b50a2bf514fc46151ae4f3
    Closes-Bug: #1888676

tags: added: in-stable-train
Marios Andreou (marios-b)
Changed in tripleo:
milestone: victoria-3 → wallaby-1
Marios Andreou (marios-b)
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
Marios Andreou (marios-b)
Changed in tripleo:
milestone: wallaby-2 → wallaby-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 12.4.0

This issue was fixed in the openstack/python-tripleoclient 12.4.0 release.

Marios Andreou (marios-b)
Changed in tripleo:
milestone: wallaby-3 → wallaby-rc1
Marios Andreou (marios-b)
Changed in tripleo:
milestone: wallaby-rc1 → xena-1
Marios Andreou (marios-b)
Changed in tripleo:
milestone: xena-1 → xena-2
Marios Andreou (marios-b)
Changed in tripleo:
milestone: xena-2 → xena-3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.