The _standalone_deploy method within tripleoclient [0] should be refactored. This method is core to our testing and development solutions and is overly complex making it fragile and difficult to maintain. We should look to remove the finishing block, separating it out into multiple private methods, which allow for them to be individually tested and vetted. Additionally we should look to remove the failed_on_rc flag from our ansible playbook execution strategy. While this process mostly works, it has resulted in several difficult to debug situations, and increases the overall complexity of the _standalone_deploy method.
1. breakup the _standalone_deploy method
2. remove failed_on_rc
2.1. always raise a suitable exception when a playbook fails.
3. squash most of the finally block into only what is required, likely captured in its own stand alone method.
[0] https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v1/tripleo_deploy.py#L1176-L1404
Related fix proposed to branch: master
Review: https:/