tripleo

deploy_identifier handling checking for wrong file in deploy_steps_playbook.yaml

Bug #1860566 reported by James Slagle
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
In Progress
Medium
James Slagle
tripleo victoria-3 "tripleo victoria"

Bug Description

--skip-deploy-identifier when passed to openstack overcloud deploy is not working as intended because the wrong file is checked on the managed nodes for existence. Since the file is never found, the anisible task(s) are always assumed to have never run, thus they will always be run (or re-run).

Essentially, --skip-deloy-identifier has no effect due to checking for:
/var/lib/tripleo-config/container-startup-config-1.json
instead of:
/var/lib/tripleo-config/container-startup-config-step_1.json

Note this only affects train since the files were modified to be directories in master, and the check was fixed at that time as well.

See original description
James Slagle (james-slagle)
Changed in tripleo:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → James Slagle (james-slagle)
milestone: none → ussuri-2
tags: added: train-backport-potential
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/703817

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/703817
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b1ac5e1e2bd793774657f0e2e67721f8218dc92b
Submitter: Zuul
Branch: stable/train

commit b1ac5e1e2bd793774657f0e2e67721f8218dc92b
Author: James Slagle <email address hidden>
Date: Wed Jan 22 10:09:49 2020 -0500

    [TRAIN ONLY] Check for correct file during --skip-deploy-identifier handling.

    At some point, the file names that are checked for existence when
    determining to apply the logic for --skip-deploy-identifier must have
    changed.

    Since the file check was not updated, it was checking for a file that
    would never exist, and so the ansible tasks were always run (or re-run).

    Effectively, --skip-deploy-identifier was broken and it had no effect.

    This patch updates the file check to use the correct name, and also
    checks the right file per step. It only applies to Train since on
    master, these files were switched to write out per container files in a
    directory, and the fix was addressed at that time.

    Change-Id: Ia01a10c488d22e38cd86b0117e9c048ea5cc3298
    Closes-Bug: #1860566

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/704792

wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-2 → ussuri-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (stable/stein)

Change abandoned by Jesse Pretorius (odyssey4me) (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/704792
Reason: It seems that stable/stein is long forgotten, so this is to be forever lost in the ether.

wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-3 → ussuri-rc3
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-rc3 → victoria-1
Emilien Macchi (emilienm)
Changed in tripleo:
milestone: victoria-1 → victoria-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.