Reviewed:  https://review.opendev.org/663595
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=a098fbc64d6442317352913bc935da812bd32b9e
Submitter: Zuul
Branch:    stable/queens

commit a098fbc64d6442317352913bc935da812bd32b9e
Author: Michele Baldessari <email address hidden>
Date:   Thu Jun 6 12:42:31 2019 +0200

    [queens-only] Increase the innodb file size by default
    
    Sometimes on queens we can get the following error:
    """
    2018-08-03 15:03:35.898 1544 ERROR oslo_messaging.rpc.server DBError: (pymysql.err.InternalError) (1118, u'The size of BLOB/TEXT data inserted in one transaction is greater than 10% of redo log size. Increase the redo log size using innodb_log_file_size.') [SQL: u'UPDATE action_executions_v2 SET updated_at=%(updated_at)s, state=%(state)s, accepted=%(accepted)s, output=%(output)s WHERE action_executions_v2.id = %(action_executions_v2_id)s'] [parameters: {'output': '{"result": {"log_path": "/tmp/ansible-mistral-actionIMP4Az/ansible.log", "stderr": "ansible-playbook 2.4.3.0\\n config file = /usr/share/ceph-ansibl ... (11486221 characters truncated) ... statements should not include jinja2 templating delimiters\\nsuch as {{ }} or {% %}. Found: {{ groups.get(mgr_group_name, []) | length > 0\\n}}\\n"}}', 'state': 'SUCCESS', 'accepted': 1, 'updated_at': datetime.datetime(2018, 8, 3, 19, 3, 35), 'action_executions_v2_id': u'f9170825-5b9c-4d41-b528-4b029a78796b'}] (Background on this error at: http://sqlalche.me/e/2j85)
    """
    
    By increasing the innodb log file size from 50MB to 256MB by default we should
    mitigate this problem considerably (rocky and onwards are not affected as config-download does
    not store the output in the DB).
    
    Tested as follows:
    1) New undercloud deploy with this patch -> correct innodb file size (256M)
    
    2) Redeploy of an existing undercloud, hereby increasing (from 50MB as default to 256M)
    
    Before:
    [root@undercloud-0 ~]# mysql -e "show variables like 'innodb_log_file_size';"
    +----------------------+----------+
    | Variable_name        | Value    |
    +----------------------+----------+
    | innodb_log_file_size | 50331648 |
    +----------------------+----------+
    
    After:
    [root@undercloud-0 ~]# mysql -e "show variables like 'innodb_log_file_size';"
    +----------------------+-----------+
    | Variable_name        | Value     |
    +----------------------+-----------+
    | innodb_log_file_size | 268435456 |
    +----------------------+-----------+
    
    mariadb indeed has increased the log file correctly:
    2019-06-06  6:03:20 139969388783808 [Warning] InnoDB: Resizing redo log from 2*3072 to 2*16384 pages, LSN=40967264
    2019-06-06  6:03:20 139969388783808 [Warning] InnoDB: Starting to delete and rewrite log files.
    2019-06-06  6:03:20 139969388783808 [Note] InnoDB: Setting log file ./ib_logfile101 size to 256 MB InnoDB: Progress in MB: 100 200
    2019-06-06  6:03:21 139969388783808 [Note] InnoDB: Setting log file ./ib_logfile1 size to 256 MB
    
    And the files are correctly resized:
    -rw-rw----. 1 mysql mysql 268435456 Jun  6 06:14 ib_logfile0
    -rw-rw----. 1 mysql mysql 268435456 Jun  6 06:03 ib_logfile1
    
    3) Tried also shrinking the DB size (to 156M) to make sure mariadb picks up the change correctly:
    2019-06-06  6:17:24 140407714523328 [Warning] InnoDB: Resizing redo log from 2*16384 to 2*9984 pages, LSN=45922683
    2019-06-06  6:17:24 140407714523328 [Warning] InnoDB: Starting to delete and rewrite log files.
    2019-06-06  6:17:24 140407714523328 [Note] InnoDB: Setting log file ./ib_logfile101 size to 156 MB InnoDB: Progress in MB: 100
    2019-06-06  6:17:24 140407714523328 [Note] InnoDB: Setting log file ./ib_logfile1 size to 156 MB InnoDB: Progress in MB: 100
    
    And the files were again correctly resized:
    -rw-rw----. 1 mysql mysql 163577856 Jun  6 06:22 ib_logfile0
    -rw-rw----. 1 mysql mysql 163577856 Jun  6 06:17 ib_logfile1
    
    Change-Id: Ie4425e7b319b39fb5bb541b17d0b909fa94c397c
    Closes-Bug: #1831875