[FFU] Hostname is case sensitive in "openstack overcloud upgrade run --nodes <HOSTNAME>" command

Bug #1802298 reported by Radoslaw Smigielski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
New
Low
Rahul Gorai

Bug Description

Some customers deploy OC using names of roles or host groups with capital letters. This can lead to situation when during upgrade "openstack overcloud upgrade run --nodes <HOSTNAME>" may fail dues to hostname mismatch.

Example:

Thursday 08 November 2018 13:17:09 +0200 (0:00:00.036) 0:00:00.808 *****
fatal: [localhost]: FAILED! => {"changed": true, "cmd": "openstack overcloud upgrade run --nodes overcloud-SriovPerformanceCompute-0 --playbook upgrade_steps_playbook.yaml --skip-tags validation",
............
.log'}, u'module_path': u'/usr/share/ansible-modules', u'nodes': u'overcloud-SriovPerformanceCompute-0', u'node_user': u'heat-admin', u'ansible_queue_name': u'upgrade'}, u'id': u'2be38f76-fc26-41b4-b773-5137b92d9b28'}}"], "stdout": "Started Mistral Workflow tripleo.package_update.v1.update_nodes. Execution ID: 2be38f76-fc26-41b4-b773-5137b92d9b28\n[u'Using /tmp/ansible-mistral-actionFVV7B0/ansible.cfg as config file',\n u' [WARNING]: Skipping unexpected key (hostvars) in group (_meta), only \"vars\",',\n u'\"children\" and \"hosts\" are valid',\n u' [WARNING]: Could not match supplied host pattern, ignoring: overcloud-',\n u'SriovPerformanceCompute-0',\n u'ERROR! Specified hosts and/or --limit does not match any hosts']", "stdout_lines": ["Started Mistral Workflow tripleo.package_update.v1.update_nodes. Execution ID: 2be38f76-fc26-41b4-b773-5137b92d9b28", "[u'Using /tmp/ansible-mistral-actionFVV7B0/ansible.cfg as config file',", " u' [WARNING]: Skipping unexpected key (hostvars) in group (_meta), only \"vars\",',", " u'\"children\" and \"hosts\" are valid',", " u' [WARNING]: Could not match supplied host pattern, ignoring: overcloud-',", " u'SriovPerformanceCompute-0',", " u'ERROR! Specified hosts and/or --limit does not match any hosts']"]}

The problem here is that node name is passed from TripleO client to Mistral workflow and Mistral generate playbooks to execute.
The main script which executes that playbook: "/tmp/ansible-mistral-XXXXXXXXXX/ansible-playbook-command.sh" use ansible --limit option.
And finally --limit option seems work more like regexp.

--nodes overcloud-SriovPerformanceCompute-0 -> FAILS
--nodes overcloud-sriovperformancecompute-0 -> PASS

Changed in tripleo:
assignee: nobody → Radoslaw Smigielski (radoslaw-smigielski)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/616542

Revision history for this message
Juan Antonio Osorio Robles (juan-osorio-robles) wrote :

Still working on this?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (master)

Change abandoned by Radoslaw Smigielski (<email address hidden>) on branch: master
Review: https://review.opendev.org/616542

Revision history for this message
Alex Schultz (alex-schultz) wrote :

This option was removed https://bugs.launchpad.net/tripleo/+bug/1824781 however this still impacts older versions (queens/rocky)

Changed in tripleo:
importance: Undecided → Low
status: In Progress → Triaged
milestone: none → train-2
assignee: Radoslaw Smigielski (radoslaw-smigielski) → nobody
tags: added: queens-backport-potential
tags: added: rocky-backport-potential
Changed in tripleo:
milestone: train-2 → train-3
Changed in tripleo:
milestone: train-3 → ussuri-1
Changed in tripleo:
assignee: nobody → Radoslaw Smigielski (radoslaw-smigielski)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/681930

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/681934

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/681971

Changed in tripleo:
assignee: Radoslaw Smigielski (radoslaw-smigielski) → Sergii Golovatiuk (sgolovatiuk)
status: Triaged → In Progress
Changed in tripleo:
milestone: ussuri-1 → ussuri-2
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-2 → ussuri-3
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-3 → ussuri-rc3
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-rc3 → victoria-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (master)

Change abandoned by Sergii Golovatiuk (<email address hidden>) on branch: master
Review: https://review.opendev.org/681971

Changed in tripleo:
milestone: victoria-1 → victoria-3
Revision history for this message
Alex Schultz (alex-schultz) wrote : auto-abandon-script

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

Changed in tripleo:
assignee: Sergii Golovatiuk (sgolovatiuk) → nobody
status: In Progress → New
tags: added: timeout-abandon
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (stable/queens)

Change abandoned by Alex Schultz (<email address hidden>) on branch: stable/queens
Review: https://review.opendev.org/681930
Reason: This review is > 90 days without comment, and failed Zuul the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results. For more details check policy https://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandonment.html

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (stable/rocky)

Change abandoned by Alex Schultz (<email address hidden>) on branch: stable/rocky
Review: https://review.opendev.org/681934
Reason: This review is > 90 days without comment, and failed Zuul the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results. For more details check policy https://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandonment.html

Changed in tripleo:
assignee: nobody → Rahul Gorai (rahulgorai22)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.