01-package-installs should fail the whole image build if it python tracebacks

Bug #1765787 reported by James Slagle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
diskimage-builder
New
Undecided
Unassigned
tripleo
Incomplete
Medium
Unassigned

Bug Description

In TripleO, we were using a badly formatted pkg-map file which was not valid JSON. This caused 01-package-installs to throw a python traceback and ValueError:

https://logs.rdoproject.org/30/558630/3/openstack-check/gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset035-master/Zc3a34f0f9f304efea55dc3ca3b4cca2d/undercloud/home/jenkins/overcloud_image_build.log.txt.gz#_2018-04-20_14_02_48

Except this didn't fail the image build, it kept going and built an image with a huge amount of missing packages.

Instead, it should have failed so we would have caught the error earlier.

Revision history for this message
Juan Antonio Osorio Robles (juan-osorio-robles) wrote :

Is this still an issue?

Revision history for this message
James Slagle (james-slagle) wrote :

not sure. i assume it is.

Changed in tripleo:
status: New → Triaged
importance: Undecided → Medium
milestone: none → train-2
tags: added: low-hanging-fruit
Changed in tripleo:
milestone: train-2 → train-3
Changed in tripleo:
milestone: train-3 → ussuri-1
Revision history for this message
Daniel Bengtsson (damani42) wrote :

Is this still an issue?

Changed in tripleo:
milestone: ussuri-1 → ussuri-2
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-2 → ussuri-3
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-3 → ussuri-rc3
wes hayutin (weshayutin)
Changed in tripleo:
status: Triaged → Incomplete
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-rc3 → victoria-1
Changed in tripleo:
milestone: victoria-1 → victoria-3
Changed in tripleo:
milestone: victoria-3 → wallaby-1
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
Changed in tripleo:
milestone: wallaby-2 → wallaby-3
Revision history for this message
Marios Andreou (marios-b) wrote :

This is an automated action. Bug status has been set to 'Incomplete' and target milestone has been removed due to inactivity. If you disagree please re-set these values and reach out to us on freenode #tripleo

Changed in tripleo:
milestone: wallaby-3 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.