Show Error Log Messages in release builds

Bug #657561 reported by Rodja
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Tomdroid
Fix Released
High
Olivier Bilodeau

Bug Description

Currently all Log.e(...) calls are disabled when setting Tomdroid.LOGGING_ENABLED to false for release builds:

if (Tomdroid.LOGGING_ENABLED) Log.e(TAG, "Problem parsing the server response", e1);

This makes debugging user error reports very hard. I suggest to remove the "if-condition" for all Log.e(..) calls, so we can get some useful error log output in released software.

Revision history for this message
Olivier Bilodeau (plaxx) wrote :

Agreed.

I would add that care should be taken to avoid bombing the logs with 300 parse errors..

Changed in tomdroid:
importance: Undecided → High
Olivier Bilodeau (plaxx)
Changed in tomdroid:
assignee: nobody → Olivier Bilodeau (plaxx)
milestone: none → 0.4.1
Olivier Bilodeau (plaxx)
Changed in tomdroid:
status: New → Fix Committed
Revision history for this message
Olivier Bilodeau (plaxx) wrote :

fix released in 0.4.1

Changed in tomdroid:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.