TextFlow

Goto line bar

Bug #240185 reported by Yuri Malheiros on 2008-06-15

Affects		Status	Importance	Assigned to	Milestone
	TextFlow	Fix Committed	Wishlist	Waldecir Loureiro dos Santos Filho	TextFlow 0.2.9

Bug Description

Goto line bar is a bottom bar like incremental search where the user put a line number and press enter ou click in a button and TextFlow show the chosen line.

Yuri Malheiros (yurimalheiros) on 2008-06-15

Changed in textflow:
importance:	Undecided → Wishlist
milestone:	none → 0.3.0

Waldecir Loureiro dos Santos Filho (waldecir) on 2008-06-16

Changed in textflow:
assignee:	nobody → waldecir
status:	New → In Progress

Revision history for this message

Waldecir Loureiro dos Santos Filho (waldecir) wrote on 2008-06-16:

goto bar diff Edit (6.3 KiB, text/plain)

i have attached the diff for this feature, please look.

Revision history for this message

Waldecir Loureiro dos Santos Filho (waldecir) wrote on 2008-06-16:

Missing file for the feature. use with the first diff Edit (4.5 KiB, text/plain)

Revision history for this message

Waldecir Loureiro dos Santos Filho (waldecir) wrote on 2008-06-17:

Full patch to goto bar feature. Edit (11.6 KiB, text/plain)

I have attached last version of goto bar feature, this patch is full, you dont need any other patch, please comment.

Revision history for this message

Yuri Malheiros (yurimalheiros) wrote on 2008-06-18:

This patch has a little bug in goto_line method in Search module.

I liked so much the real time verification of line number.

Two things that you need do fix are:
* Negative numbers must be invalid numbers.
* If you put a character in entry, this line:

gotoline = int(self.entry.get_text())

returns a error. Catch the exception and change the entry background to red.

Revision history for this message

Waldecir Loureiro dos Santos Filho (waldecir) wrote on 2008-06-19:

goto bar diff Edit (11.9 KiB, text/x-diff)

I make some fixes for characters and negative numbers.

now i think this is stable.

Revision history for this message

Yuri Malheiros (yurimalheiros) wrote on 2008-06-20:

It's cool. One more thing... if you put a number greater than the total lines of file the cursor must stay at the current line.

Revision history for this message

Waldecir Loureiro dos Santos Filho (waldecir) wrote on 2008-06-20:

Incremental patch for correct if choose a line greater than lines in file. Edit (716 bytes, text/plain)

here is the incremental patch. You will need last full patch to apply this.

Yuri Malheiros (yurimalheiros) on 2008-06-20

Changed in textflow:
status:	In Progress → Fix Committed

Revision history for this message

Tiago Sousa (tiagoboldt) wrote on 2008-09-23:

Adding a keyboard shortcut would also be great: )

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

Add patch

Bug attachments

goto bar diff Edit

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.