Duplicated scenario name will induce error in py33

Robert: I have made a patch for this issue, but I can not find the repository url. Would you show me some guidance please ?

Here is the patch:
---------------------------------

--- scenarios.py.old 2013-10-25 06:21:18.920665452 +0800
+++ scenarios.py 2013-10-25 05:47:21.984585100 +0800
@@ -36,12 +36,13 @@

 def apply_scenario(scenario, test):
     """Apply scenario to test.
-
+
     :param scenario: A tuple (name, parameters) to apply to the test. The test
         is cloned, its id adjusted to have (name) after it, and the parameters
         dict is used to update the new test.
     :param test: The test to apply the scenario to. This test is unaltered.
     :return: A new test cloned from test, with the scenario applied.
+
     """
     name, parameters = scenario
     scenario_suffix = '(' + name + ')'
@@ -59,10 +60,22 @@
 def apply_scenarios(scenarios, test):
     """Apply many scenarios to a test.

+ Duplicate name in scenarios is not permitted.
     :param scenarios: An iterable of scenarios.
     :param test: A test to apply the scenarios to.
     :return: A generator of tests.
     """
+ seen = set()
+ duplicated = []
+ for (name, para) in scenarios:
+ if name not in seen:
+ seen.add(name)
+ else:
+ duplicated.append((name,para))
+
+ if duplicated:
+ raise Exception("Duplicated name defined in scenarios:", duplicated)
+
     for scenario in scenarios:
         yield apply_scenario(scenario, test)

Robert: The change needs a corresponding test case in tests/test_scenarios.py. But I don't konw how to test it. Would you give me some help please ?

yes, Robert

@Kui hi, sorry for the slow response. ETOOMUCHMAIL.

bzr branch lp:testscenarios will get you trunk code. Or you can attach a patch here.

Cheers,
Rob

That said, I suspect its up to the runner to really address this, not sure if we need to cater specifically here or not.

So, to wrap this up:
 - because generation is potentially local, this is best handled and reported globally by the runner
 - testtools now does this.

Closing this