Terminal font setting is always disabled by default

Bug #1160367 reported by Cleydyr de Albuquerque
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Terra Terminal Emulator
In Progress
Undecided
Unassigned

Bug Description

When in Preferences menu, Terminal tab, General section, the Font option is disabled (see attached screenshot), even if you don't choose to use system font. Nevertheless, checking "use system default font" and unchecking again makes it possible to set font again.

Revision history for this message
Cleydyr de Albuquerque (cleydyr) wrote :
Özcan ESEN (ozcanesen)
Changed in terra:
status: New → In Progress
Revision history for this message
Cleydyr de Albuquerque (cleydyr) wrote :

Maybe if we change the order of the commands in preferences.py from

self.chk_use_system_font.connect('toggled', lambda w: self.font_name.set_sensitive(not self.chk_use_system_font.get_active()))
self.chk_use_system_font.set_active(ConfigManager.get_conf('use-default-font'))

to
self.chk_use_system_font.set_active(ConfigManager.get_conf('use-default-font'))
self.chk_use_system_font.connect('toggled', lambda w: self.font_name.set_sensitive(not self.chk_use_system_font.get_active()))

It solves the problem, I guess.

Revision history for this message
Cleydyr de Albuquerque (cleydyr) wrote :

Actually, the previous change has no relevance. It suffices to add

self.font_name.set_sensitive(ConfigManager.get_conf('use-default-font'))

right after self.font_name was initialized in preferences.py init_ui method.

Revision history for this message
Aşkın Yollu (askin) wrote :

@cleydyr there is a little mistake

self.font_name.set_sensitive(not ConfigManager.get_conf('use-default-font'))

Revision history for this message
Cleydyr de Albuquerque (cleydyr) wrote :

@askin Yeah. You're right. Sorry for the double mistake.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.