Zoom and maximise do not work if single terminal in a tab
Bug #1501106 reported by
Stephen Boddy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Terminator |
In Progress
|
Low
|
Stephen Boddy | ||
Bug Description
The maximise and zoom have no effect if there is a single terminal under a tab,
Open a window create a new tab, and split it.
On the tab with splits, max/zoom expands to fill whole window.
On the tab with one terminal, max/zoom has no effect.
This might be intended, but I'm not keen. I prefer consistency for these kind of things, an IMO the terminal should still expand, hiding the tabs.
This is present in both 0.98 and gtk3 versions.
| description: | updated |
Revision history for this message
| Stephen Boddy (stephen-j-boddy) wrote | #1 |
| Changed in terminator: | |
| assignee: | nobody → Stephen Boddy (stephen-j-boddy) |
| status: | Triaged → In Progress |
Revision history for this message
| Egmont Koblinger (egmont-gmail) wrote | #2 |
Revision history for this message
| Stephen Boddy (stephen-j-boddy) wrote | #3 |
To post a comment you must log in.
Just tracking some notes here so I don't lose them.
In notepad::newtab when connecting signals
'zoom': top_window.zoom,
'maximise': [top_window.zoom, False],
Have to be added, but that causes an exception in a deferred call to terminals ensure_
For some reason at this point the top_level of the terminal is a notebook, not a window, so there is an exception, although it still seems to work. This can be tested and avoided with:
if not maker.isinstanc
return
ensure_
on_tab_switch is called by notebook:
do_deferred_
deferred_
'switch-page' happens because the tab containing the child is removed because it is empty.
This also manifests that un-max/zoom place the terminal in a new tab at the end of the list of tabs.
Perhaps need to temporarily disconnect switch-tab signal when disconnecting, and if direct parent of terminal is a notebook, get the index and store it for when restoring.