Replace Tempest tox deprecated 'all-plugin' env to 'all' env

Fix proposed to branch: master
Review: https://review.opendev.org/706384

Fix proposed to branch: stable/train
Review: https://review.opendev.org/706385

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/706415

We can force-merge the above.

Affected master branches:
http://codesearch.openstack.org/?q=%5Cball-plugin%5Cb&i=nope&files=zuul%5C.&repos=

^ could one tweak codesearch to search in other branches too?

DSVM part: http://codesearch.openstack.org/?q=DEVSTACK_GATE_TEMPEST_ALL_PLUGINS.*%3D.*1&i=nope&files=&repos=
(thanks, Jens, for pointing this out)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/706699

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/706700

Change abandoned by Ghanshyam Mann (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/706415
Reason: right backport- https://review.opendev.org/#/c/706699/

Reviewed: https://review.opendev.org/706385
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=29182a4552a17c1a51cb1930a818cd95a95d3266
Submitter: Zuul
Branch: stable/train

commit 29182a4552a17c1a51cb1930a818cd95a95d3266
Author: Ghanshyam <email address hidden>
Date: Thu Feb 6 14:39:29 2020 -0600

    Use Tempest 'all' tox env

    Tempest recently moved tox default
    to py3 including all-plugin env.
    -https://review.opendev.org/#/c/703011/

    This will fail the py2 jobs which are using
    all-plugin tox env. Because tox all-plugin
    env var enable the sitepackages=True. Py2 jobs
    install the tempest plugins on py2 and all-plugin
    tox try to find the installed plugins on py3 which
    cause no test to run and fail the job.

    tox all-plugin has been deprecated since long and not
    supposed to use for plugins who already in migrated to
    separate repo in queens cycle.

    Using tox 'all' env to fix the issue.

    Change-Id: Ib1a2be90c0b3dbacc6daf52f0fc6f326ab47fc98
    Closes-Bug: 1862240

Reviewed: https://review.opendev.org/706384
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=4f3883775dc435fb76250d854aa460bc9ca25433
Submitter: Zuul
Branch: master

commit 4f3883775dc435fb76250d854aa460bc9ca25433
Author: Ghanshyam <email address hidden>
Date: Thu Feb 6 14:39:29 2020 -0600

    Use Tempest 'all' tox env

    Tempest recently moved tox default
    to py3 including all-plugin env.
    -https://review.opendev.org/#/c/703011/

    This will fail the py2 jobs which are using
    all-plugin tox env. Because tox all-plugin
    env var enable the sitepackages=True. Py2 jobs
    install the tempest plugins on py2 and all-plugin
    tox try to find the installed plugins on py3 which
    cause no test to run and fail the job.

    tox all-plugin has been deprecated since long and not
    supposed to use for plugins who already in migrated to
    separate repo in queens cycle.

    Using tox 'all' env to fix the issue.

    Change-Id: Ib1a2be90c0b3dbacc6daf52f0fc6f326ab47fc98
    Closes-Bug: 1862240

Reviewed: https://review.opendev.org/706699
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=36086c73df5d1552e531bc0729207bb2bd875ac8
Submitter: Zuul
Branch: stable/stein

commit 36086c73df5d1552e531bc0729207bb2bd875ac8
Author: Ghanshyam <email address hidden>
Date: Thu Feb 6 18:13:13 2020 -0600

    Use Tempest 'all' tox env

    Tempest recently moved tox default
    to py3 including all-plugin env.
    -https://review.opendev.org/#/c/703011/

    This will fail the py2 jobs which are using
    all-plugin tox env. Because tox all-plugin
    env var enable the sitepackages=True. Py2 jobs
    install the tempest plugins on py2 and all-plugin
    tox try to find the installed plugins on py3 which
    cause no test to run and fail the job.

    tox all-plugin has been deprecated since long and not
    supposed to use for plugins who already in migrated to
    separate repo in queens cycle.

    Enable designate-tempest-plugin and using tox 'all' env
    to fix the issue.

    Change-Id: Ib1a2be90c0b3dbacc6daf52f0fc6f326ab47fc98
    Closes-Bug: 1862240

Reviewed: https://review.opendev.org/706700
Committed: https://git.openstack.org/cgit/openstack/designate/commit/?id=0566f104ccf1b30a7f95d05fe20a238d01888dc5
Submitter: Zuul
Branch: stable/rocky

commit 0566f104ccf1b30a7f95d05fe20a238d01888dc5
Author: Ghanshyam <email address hidden>
Date: Thu Feb 6 18:13:13 2020 -0600

    Use Tempest 'all' tox env

    Tempest recently moved tox default
    to py3 including all-plugin env.
    -https://review.opendev.org/#/c/703011/

    This will fail the py2 jobs which are using
    all-plugin tox env. Because tox all-plugin
    env var enable the sitepackages=True. Py2 jobs
    install the tempest plugins on py2 and all-plugin
    tox try to find the installed plugins on py3 which
    cause no test to run and fail the job.

    tox all-plugin has been deprecated since long and not
    supposed to use for plugins who already in migrated to
    separate repo in queens cycle.

    Enable designate-tempest-plugin and using tox 'all' env
    to fix the issue.

    Change-Id: Ib1a2be90c0b3dbacc6daf52f0fc6f326ab47fc98
    Closes-Bug: 1862240

This issue was fixed in the openstack/designate 7.0.1 release.

Related fix proposed to branch: master
Review: https://review.opendev.org/750375

This is in progress and there is a patch addressing this:
https://review.opendev.org/#/c/750375/

We're just waiting for other consumers of the all-plugin env until they replace its usage by 'all' tox env -> https://review.opendev.org/#/q/topic:fix/tox_env+(status:open+OR+status:merged)

All the consumers switched to 'all' env -> https://review.opendev.org/#/q/topic:fix/tox_env+(status:open+OR+status:merged)

However we cannot delete 'all-plugin' tox env from tempest yet as there are many jobs that might be using it on stable branches gates. Once all stable branches of all tempest consumers switched to the new 'all' tox env, we can proceed and delete 'all-plugin' from tempest by https://review.opendev.org/#/c/750375/

Until then I'm gonna move this back to Confirmed.

Reviewed: https://review.opendev.org/c/openstack/tempest/+/860719
Committed: https://opendev.org/openstack/tempest/commit/be19f218138c7ab391eed1382cfa632a41bf0b0b
Submitter: "Zuul (22348)"
Branch: master

commit be19f218138c7ab391eed1382cfa632a41bf0b0b
Author: Lukáš Piwowarski <email address hidden>
Date: Fri Oct 7 13:47:11 2022 +0200

    Remove references to 'all-plugin' tox environment

    The 'all-plugin' tox environment was deprecated by this patch [1].
    Instead of the 'all-plugin' it is recommended to use the 'all' tox
    environment.

    This patch removes any reference to 'all-plugin' tox environment and
    updates the documentation so that the installation steps work with
    the 'all' tox venv.

    [1] https://review.opendev.org/c/openstack/tempest/+/543974

    Related-Bug: 1862240
    Change-Id: I0a86d9cf33bff6576a6337967d6b663ab7d9f4a6

Just for the record:

"
kopecmartin hmm, also jobs on stable/branches can't use that env, only then we can remove it
kopecmartin i'm checking old comments here
kopecmartin #link https://bugs.launchpad.net/tempest/+bug/1862240
lpiwowar I think it was done: https://codesearch.opendev.org/?q=all-plugin&i=nope&literal=nope&files=&excludeFiles=&repos= , wasn't it?
lpiwowar I see no job using the all-plugin.
kopecmartin based on the bug description, only old py2 jobs were using that, we don't have those anymore, so it looks like it could be safe to delete that finally from tempest
kopecmartin what do you think gmann?
gmann lpiwowar: kopecmartin: only thing I am worried about it devstack-gate using it https://opendev.org/openstack/devstack-gate/src/branch/master/devstack-vm-gate.sh#L889
gmann lpiwowar: kopecmartin: we cannot do modification in devstack-gate as it is deprecated for retirement and hopefully it will go away soon. let's wait for devstack-gate retirement and then it will be safe to remove
gmann whoami-rajat: thanks for checking and patch link. yeah we cannot release EM but let me check if we can make job using latest os-brick and if that work
"

https://meetings.opendev.org/irclogs/%23openstack-qa/%23openstack-qa.2023-05-16.log.html