Tea Time

Feature request: Pause button in Tea Time

Bug #903635 reported by Julien on 2011-12-13

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	Tea Time	In Progress	Wishlist	Unassigned

Bug Description

Hi Pavel
May I suggest to add a Pause button in Tea Time? This would be extremely useful, when working on a task and being interrupted by colleague or phone call. That's one feature I really miss from timer-applet.
Thanks!

Revision history for this message

Julien (jucor) wrote on 2011-12-26:

Add Pause and encapsulate Timer to make sure I'm not messing anything Edit (11.6 KiB, text/plain)

Hi Pavel
My first contribution to open source: a patch to add a Pause feature. I tried to stick to your coding style. I encapsulated the Timer class to make sure that my change was not messing any method from external objects.
All the best, let me know if you've questions!
Cheers and merry Xmas!

Changed in teatime:
assignee:	nobody → Julien (jucor)

Julien (jucor) on 2011-12-26

Changed in teatime:
status:	New → Fix Committed

Pavel Rojtberg (rojtberg) on 2012-04-29

Changed in teatime:
importance:	Undecided → Wishlist

Revision history for this message

Pavel Rojtberg (rojtberg) wrote on 2012-04-29:

hi julien. thanks for your patch, however I am not copletely convinced I should apply it. Tea Time is designed to be an egg-timer and I am a fan of interfaces allowing only to do as much as necessary.
Your "pausing" usecase is not a common one when using tea time as it is intended and would double the amount of buttons...

I suppose you need this when applying the pomodoro technique? If so, there is a branch of Tea Time specifically created to add pomodoro related features. [1] If you want, I can merge your patch there and grand you commit rights to it.
For supporting pomodoro properly, you might also want to look at at the current blueprints like [2].
Note however I am not actively developing the pomodoro branch, but I would like to share code with trunk if someone steps up for the pomodoro development.

[1] https://code.launchpad.net/teatime
[2] https://blueprints.launchpad.net/teatime/+spec/timers-queue

Changed in teatime:
status:	Fix Committed → In Progress

Revision history for this message

Julien (jucor) wrote on 2012-04-30:

Hi Pavel

Thanks for your answer. Well, you're the maintainer, up to you to decide what you apply or not :) As far as I'm concerned, after having used the patched version much to my content for a while, I have moved away from Unity (in favour of awesome window manager [1]), so I'm not using teatime anymore.

I was using the pause button for long tasks (up to 1 hour - 1 second), for which I had a risk of being interrupted. For pomodoro, actually, I was using pomodoro-indicator [2]: it lacked a GUI Control to set the durations, but had a "pause" feature and automatic switch from activity to rest. Your pomodoro branch's maintainer might want to contact its developer to unite their efforts.

All the best,
Julien
[1] http://awesome.naquadah.org/
[2] https://launchpad.net/pomodoro-indicator