tarmac does not load plugins from ~/.config/tarmac/plugins
Bug #686570 reported by
Māris Fogels
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Tarmac |
Fix Released
|
High
|
dobey | ||
Bug Description
Tarmac does not load plugins from ~/.config/
Related branches
lp://staging/~mars/tarmac/fix-plugin-import
- Māris Fogels (community): Approve
-
Diff: 112 lines (+43/-6)3 files modifiedtarmac/plugin.py (+5/-1)
tarmac/plugins/allowedcontributors.py (+23/-3)
tarmac/plugins/tests/test_allowedcontributors.py (+15/-2)
- Paul Hummer: Disapprove
-
Diff: 29 lines (+5/-1)1 file modifiedtarmac/plugin.py (+5/-1)
lp://staging/~dobey/tarmac/home-loader
- Mike McCracken: Approve
-
Diff: 455 lines (+174/-104)14 files modifiedtarmac/plugin.py (+21/-13)
tarmac/plugins/tests/test_allowedcontributors.py (+1/-1)
tarmac/plugins/tests/test_bugresolver.py (+1/-1)
tarmac/plugins/tests/test_command.py (+1/-1)
tarmac/plugins/tests/test_commitmessage.py (+1/-1)
tarmac/plugins/tests/test_recipebuilder.py (+1/-1)
tarmac/plugins/tests/test_votes.py (+1/-1)
tarmac/tests/__init__.py (+60/-2)
tarmac/tests/mock.py (+0/-80)
tarmac/tests/plugins/testplugin.py (+23/-0)
tarmac/tests/test_branch.py (+1/-1)
tarmac/tests/test_commands.py (+1/-1)
tarmac/tests/test_plugin.py (+61/-0)
tarmac/tests/test_registry.py (+1/-1)
| Changed in tarmac: | |
| assignee: | nobody → Māris Fogels (mars) |
| status: | New → In Progress |
Revision history for this message
| dobey (dobey) wrote | #1 |
Revision history for this message
| Māris Fogels (mars) wrote | #2 |
| Changed in tarmac: | |
| assignee: | Māris Fogels (mars) → nobody |
| status: | In Progress → Confirmed |
| Changed in tarmac: | |
| importance: | Undecided → High |
| Changed in tarmac: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Rodney Dawes (dobey) |
| Changed in tarmac: | |
| status: | In Progress → Fix Committed |
| Changed in tarmac: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think the code (probably in bzrlib too), needs to perhaps switch over to using imp.find_module() and imp.load_module(), to do the plug-in loading. Doing the exec 'import foo' is extra nasty. Even just doing __import__() instead would at least be better code, even if it doesn't solve this specific bug.
(copied from the rejected merge proposal)