Should ignore authors and proposer for votes counting
Bug #683351 reported by
dobey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Tarmac |
Triaged
|
Medium
|
Unassigned | ||
Bug Description
Currently, the votes plug-in is counting all votes that are from valid reviewers. However, if the author or requestor of the merge is a valid reviewer, it will count that vote as well, but should probably ignore it. By counting those votes, it provides a means to circumvent policy enforcement with the votes plug-in, by allowing that person to approve their own merge.
Revision history for this message
| JC Hulce (soaringsky) wrote | #1 |
| Changed in tarmac: | |
| status: | In Progress → Triaged |
| Changed in tarmac: | |
| assignee: | Rodney Dawes (dobey) → nobody |
To post a comment you must log in.
This is a good idea, but it isn't relevant for all applications and should be configurable. For example, what if a project asks the committer to verify the diff as part of the review?