File plugin never watches file changes using inotify
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Tangerine |
New
|
Undecided
|
Unassigned |
Bug Description
FilePlugin.cs and Daemon.cs use #if LINUX or #if LINUX || MACOSX conditional sections to decide whether or not to use the Inotify daemon.
Firstly, the inotify-specific code should be using HAVE_INOTIFY. Only the Linux/MAC OS X specific code (e.g. UNIX signal handling) should use LINUX or MACOSX defines.
Secondly, the decision about platform made in configure.ac is not propagated to the compiled code. The LINUX define is unconditionally set for the main Tangerine assembly - it's always set by the MCS_FLAGS line in Tangerine/
I've created a patch against the development branch of Tangerine that fixes both these issues, and also prints a log warning if HAVE_INOTIFY is not defined.