Windows style line endings issue

Bug #1817283 reported by dharmendra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tacker
Fix Released
Medium
dharmendra

Bug Description

Some codes in Tacker use Windows style line endings, this violates H903 error pep8 in py3 env.

2019-02-20 08:31:42.637263 | ubuntu-xenial | /home/zuul/src/git.openstack.org/openstack/tacker$ /home/zuul/src/git.openstack.org/openstack/tacker/.tox/pep8/bin/flake8
2019-02-20 08:31:48.754707 | ubuntu-xenial | ./tacker/vnfm/policy_actions/vdu_autoheal/vdu_autoheal.py:1:2: H903 Windows style line endings not allowed in code
2019-02-20 08:31:48.754807 | ubuntu-xenial | #
2019-02-20 08:31:48.754846 | ubuntu-xenial | ^
2019-02-20 08:31:48.755068 | ubuntu-xenial | ./tacker/vnfm/policy_actions/vdu_autoheal/vdu_autoheal.py:2:77: H903 Windows style line endings not allowed in code
2019-02-20 08:31:48.755223 | ubuntu-xenial | # Licensed under the Apache License, Version 2.0 (the "License"); you may
2019-02-20 08:31:48.755379 | ubuntu-xenial | ^

Changed in tacker:
assignee: nobody → dharmendra (dharmendra-kushwaha)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tacker (master)

Fix proposed to branch: master
Review: https://review.openstack.org/638620

Changed in tacker:
status: New → In Progress
Changed in tacker:
importance: Undecided → Medium
milestone: none → stein-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tacker (master)

Reviewed: https://review.openstack.org/638620
Committed: https://git.openstack.org/cgit/openstack/tacker/commit/?id=675a3e913c75de548d00cc3eb6fb96d590757f96
Submitter: Zuul
Branch: master

commit 675a3e913c75de548d00cc3eb6fb96d590757f96
Author: dharmendra <email address hidden>
Date: Fri Feb 22 10:17:35 2019 +0000

    Remove H903 error in source.

    Some codes use Windows style line endings, this violates H903 error pep8.
    This patch will convert dos to unix formate.

    Change-Id: Idd3da3a259517e1b8612b3c3c129a1f8616403bb
    Closes-Bug: #1817283

Changed in tacker:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tacker 1.0.0.0rc1

This issue was fixed in the openstack/tacker 1.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.