Switchboard Notifications Plug

Apps aren't removed when they're uninstalled

Bug #1406799 reported by Danielle Foré
66
This bug affects 11 people
Affects Status Importance Assigned to Milestone
Switchboard Notifications Plug
Fix Released
Medium
Marcus Wichelmann
Switchboard Notifications Plug 0.1.1

Bug Description

This is probably a consequence of our discovery method, but it seems there's not a mechanism to detect that an app has been uninstalled

Related branches

lp://staging/~l-admin-3/switchboard-plug-notifications/code-cleanup-and-new-backend
xapantu (community): Approve
Rico Tzschichholz: Abstain
Danielle Foré: Needs Fixing
Diff: 1970 lines (+922/-882)
17 files modified
data/notify-center.svg (+81/-0)
po/notifications-plug.pot (+46/-54)
src/Backend/App.vala (+34/-0)
src/Backend/NotifyManager.vala (+63/-0)
src/Backend/NotifySettings.vala (+36/-0)
src/CMakeLists.txt (+9/-5)
src/NotifySettings.vala (+0/-64)
src/Plug.vala (+90/-82)
src/Widgets/AppEntry.vala (+94/-237)
src/Widgets/AppList.vala (+76/-100)
src/Widgets/AppSettingsView.vala (+107/-152)
src/Widgets/Footer.vala (+31/-23)
src/Widgets/InfoScreen.vala (+0/-66)
src/Widgets/MainView.vala (+72/-99)
src/Widgets/SettingsHeader.vala (+50/-0)
src/Widgets/SettingsOption.vala (+74/-0)
src/Widgets/Sidebar.vala (+59/-0)
Revision history for this message
Marcus Wichelmann (l-admin-3) wrote :

That's right. The problem is, that we couldn't compare the list of installed apps with the list of the recognized one, because the application-ids and the notification-ids are different. As long as that's so inconsistent such a feature would cause many problems...

Revision history for this message
Danielle Foré (danrabbit) wrote :

Indeed. So it sounds like we need to be using the .desktop entry to discover apps. In that way, we have a theoretically up-to-date list of installed apps that send notifications. We just have to make sure all our default apps are using this key and hope that 3rd party apps do the right thing.

Revision history for this message
Marcus Wichelmann (l-admin-3) wrote :

So any compatible app should (1) use the X-GNOME-UsesNotifications=true key in it's .desktop-file and (2) should register itself using the same name as set in the .desktop-file on the notifications-server. And if gala couldn't assign a .deskop-file with the specific key to a registered app it should ignore all settings and just show the notification...?

Marcus Wichelmann (l-admin-3)
Changed in switchboard-plug-notifications:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Danielle Foré (danrabbit) wrote :

yes, I think that is probably the best way we can make sure that we have an accurate list of installed apps

Revision history for this message
Julian (julian-pe) wrote :

Same problem.
But Spotify does strange things, too :-(

Danielle Foré (danrabbit)
Changed in switchboard-plug-notifications:
milestone: none → loki-beta1
Marcus Wichelmann (l-admin-3)
Changed in switchboard-plug-notifications:
status: Confirmed → In Progress
assignee: nobody → Marcus Wichelmann (l-admin-3)
Revision history for this message
TC (smalltimer) wrote :

Also, there are multiple entries for some apps! I installed R-studio and there are 5 entries for the same app. There is also an entry titled 'unknown'. I submitted a bug, but I think this report pretty much addresses the main problem.

Revision history for this message
Marcus Wichelmann (l-admin-3) wrote :

You're right, the reason for the bug is the same. Mostly this is caused by a problem with the code of these third-party apps, but anyway, Im working on making this behaviour better with the new-backend branch on top.

Cody Garver (codygarver)
Changed in switchboard-plug-notifications:
status: In Progress → Fix Committed
Danielle Foré (danrabbit)
Changed in switchboard-plug-notifications:
milestone: loki-beta1 → loki-alpha1
Revision history for this message
Scard (scard) wrote :

Does someone know where we can remove these old apps by hand?

Cody Garver (codygarver)
Changed in switchboard-plug-notifications:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.