shard audit exaggerates reports of overlapping shard ranges
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Object Storage (swift) |
Confirmed
|
Undecided
|
Matthew Oliver |
Bug Description
When sharder audits a root container and finds overlapping ranges, there is a tendency for each overlap to be logged more than once. For, example the following might be logged:
Audit failed for root var/folders/
This can be illustrated by changing a unit test to assert that both variations of the same overlap are logged:
diff --git a/test/
index 22cd86797.
--- a/test/
+++ b/test/
@@ -4397,6 +4397,9 @@ class TestSharder(
+ self.assertIn(
+ 'overlapping ranges in state %s: s-z k-t' % state_text,
+ line)
(based on commit 257041aff)
Changed in swift: | |
assignee: | nobody → Matthew Oliver (matt-0) |
Changed in swift: | |
status: | New → Confirmed |
This is because your ShardRange.__lt__ isn't sensitive to overlaps. Just whole range differences. Ie. self.upper < other.lower. Which doesn't work in an overlap