test.unit.cli.test_ringbuilder should consisently use run_srb
Bug #1656440 reported by
clayg
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Object Storage (swift) |
In Progress
|
Wishlist
|
Nick Miethe |
Bug Description
We have some awesome test infrastructure in the RunSwiftRingBui
Places where we manually make lists of args and manually pass them to ringbuilder.main and expect them to return 0 should *definitely* be rewritten to use run_srb
e.g.
Should just be:
self.
I think we should also update the signature of run_srb to be:
status, out, err = self.run_srb
and maybe drop assertSystemExit in favor of
self.
Or maybe even better add some asserts around the output in addition to just the exit code!
To post a comment you must log in.
I agree that run_srb removes unnecessary code of making lists of args and passing to ringbuilder.main and its usage would help prevent fat-fingering.