file-failures doesn't scale with a large number of build failures
Bug #760722 reported by
Matthias Klose
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Svammel (UNMAINTAINED) |
Confirmed
|
High
|
Unassigned | ||
Bug Description
the script currently builds up a complete list of packages to examine before actually starting to do anything. this doesn't scale well with a large number of build failures (or think about scanning all successful build logs). so it would be better to apply *all* the logic for one build record completely before examining the next one, i.e:
for b in getBuildRecords (FAILED_BUILDS)
- check if superseded
- check if built on reference arch
- check if bug already filed
- file bug
Revision history for this message
| Mattias Backman (mabac) wrote | #1 |
Revision history for this message
| Mattias Backman (mabac) wrote | #2 |
| Changed in svammel: | |
| importance: | Undecided → High |
| milestone: | none → 0.1.1 |
| status: | New → Confirmed |
| Changed in svammel: | |
| assignee: | nobody → Mattias Backman (mabac) |
| Changed in svammel: | |
| milestone: | 0.1.1 → 0.1.2 |
| Changed in svammel: | |
| milestone: | 0.1.2 → none |
| Changed in svammel: | |
| assignee: | Mattias Backman (mabac) → nobody |
To post a comment you must log in.
Hi,
You're right about that. I'll work on rearranging this as soon as some ongoing basic changes are done.
There probably are a few more possible improvements now that I know more about how you're actually using the script. For instance now all passed archives are treated equal, all are checked for failed builds and cross referenced for later successful builds. I thought this was clever but the benefits might be purely academic while there is a real performance penalty.
A less generic solution would be to be explicit about which archive serves which purpose like
- target-archive - assumed to contain only builds for target-architecture and is scanned only for failed builds. Only file bugs on packages found to fail to build in here.
- reference-archive - assumed to only contain builds for reference-
- main-archive - scanned only for successful builds for interesting packages on target-architecture
Perhaps that's closer to the actual use case and also would make using the script more obvious?
What you would loose is the possibility to run the script on only a mixed archive and let it use itself as reference, but that's a use case I just assumed and might not be interesting?
Thanks,
Mattias