Support GMenu indicators

Bug #1347633 reported by quequotion
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Super Wingpanel
In Progress
Undecided
Unassigned

Bug Description

Several important upstream indicators are no longer compatible with super-wingpanel(-unstable(-bzr))

In particular these will not load at all:

(os-patch-)indicator-session(-trusty)
(os-patch-)indicator-datetime(-trusty)
(os-patch-)indicator-sound(-trusty)

there are probably more, but I haven't tested everything yet.

These indicators work in wingpanel-bzr.

The API for these indicators has changed significantly since super-wingpanel forked from wingpanel.

The changes that have these working in wingpanel need to be located and imported into super-wingpanel.

Revision history for this message
quequotion (quequotion) wrote :

It looks like this will be very possible.

The merges need to happen starting with wingpanel version 150:

http://bazaar.launchpad.net/~elementary-pantheon/wingpanel/0.3.x/revision/150

Revision history for this message
quequotion (quequotion) wrote :

Done?

Maybe I got this done.

This patch is a collection of indicator-related cherry pics from Wingpanel r150 onward.

Can confrim os-patch-indicator-datetime trusty and os-patch-indicator-sound-trusty working.

Changed in super-wingpanel:
status: New → In Progress
Revision history for this message
quequotion (quequotion) wrote :

Good news: indicator-datetime, indicator-session, and indicator-sound all work!

Bad news: indicator-session and indicator-sound are out of place, immediately to the right of indicator-datetime (which is correctly on the far left). I suspect they are all on the left end because of some unimplemented sorting for the unity indicators.

So far tested inly in slim mode.

Revision history for this message
quequotion (quequotion) wrote :

indicator-datetime (os-patch-indicator-datetime-pantheon) is unstable with super-wingpanel.

It usually appears for a while at the beginning of the session and then blinks out of existence sometime later.

Also, the calendar never appears.

I can't be sure if this is because of the newer version of indicator-datetime missing something it wants to interact with or if it just doesn't like super-wingpanel.

Revision history for this message
quequotion (quequotion) wrote :

Compatibility for Unity 7 system indicators

Revision history for this message
quequotion (quequotion) wrote :

indicator-datetime seems to have stabilized with the new sorting. I actually expected that would happen!

Apparently indicator-datetime is very particular about it's placement, and won't tolerate being to the left of indicator-appmenu.

So, as shown in the patch above the appmenu must appear first in the list of indicators and datetime after it.

Still a little bugginess though: datetime sometimes loses the "Time and Date Settings" link and occasionally the clock (the indicator is still there, and can be clicked on, but appears as an empty gap between appmenu and keyboard)

quequotion (quequotion)
summary: - Update indicator handling
+ Support GMenu indicators
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.