testtools.run --list-tests exits 0 when discover fails to import
Bug #1245672 reported by
Matthew Treinish
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| subunit |
Fix Released
|
Critical
|
Robert Collins | ||
| testtools |
Fix Released
|
Critical
|
Robert Collins | ||
Bug Description
If there is an error or an issue with a test file when testtools.run --list-tests is run that would cause the file to fail on import then the command still exits with 0 despite the import failure. The test list just contains an entry with the test_id being:
unittest.
for each file that fails to be imported
Related branches
| Changed in testtools: | |
| status: | New → Triaged |
| importance: | Undecided → Critical |
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
Revision history for this message
| Robert Collins (lifeless) wrote | #2 |
| Changed in subunit: | |
| status: | New → Triaged |
| importance: | Undecided → Critical |
| Changed in testtools: | |
| status: | Triaged → Fix Committed |
| Changed in testtools: | |
| milestone: | none → next |
| Changed in testtools: | |
| status: | Fix Committed → Fix Released |
| Changed in subunit: | |
| status: | Triaged → Fix Committed |
| assignee: | nobody → Robert Collins (lifeless) |
| Changed in testtools: | |
| assignee: | nobody → Robert Collins (lifeless) |
| Changed in subunit: | |
| milestone: | none → next |
| Changed in subunit: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
So this breaks testrepository quite badly, because it does (pseudo code):
tests = --list-tests
filter tests by user pattern
run selected tests
And if the users pattern doesn't match unittest.
I think testtools can do something here - e.g. list-tests should exit 1 if a module failed to import.