subiquity

Getting a swap file even when a swap partition is added

Bug #1927103 reported by Stéphane Graber on 2021-05-04

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	subiquity	Fix Committed	Undecided	Mauricio Faria de Oliveira

Bug Description

Recently deploying a number of 20.04 systems, I was very surprised to find a /SWAP.img file and matching /etc/fstab entry despite me having added a dedicated swap partition through subiquity.

I'd have expected subiquity to skip the swap file creation if a dedicated partition is used.

Tags:

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2021-05-05:

Yes, that's definitely what should have happened. Can you attach or send me /var/log/installer from one of these systems?

Revision history for this message

Stéphane Graber (stgraber) wrote on 2021-05-05:

installer.tar.gz Edit (127.8 KiB, application/x-tar)

Attached the installer logs

Michael Hudson-Doyle (mwhudson) on 2021-05-10

tags:

added: fr-1359

Revision history for this message

Michael Hudson-Doyle (mwhudson) wrote on 2021-05-10:

Ah right this is fallout from the client/server split. Should be easy to fix.

Changed in subiquity:
status:	New → Triaged

Michael Hudson-Doyle (mwhudson) on 2021-05-12

Changed in subiquity:
status:	Triaged → Fix Committed

Revision history for this message

Thomas (teclab-at) wrote on 2021-09-23:

still happening in 20.04.3

Revision history for this message

Mauricio Faria de Oliveira (mfo) wrote on 2022-10-19:

This is reproducible with the main branch (commit 43d1206855d4),
so apparently the Fix Committed status isn't accurate right now.

Pull Request submitted, test steps in there.

https://github.com/canonical/subiquity/pull/1459

Changed in subiquity:
status:	Fix Committed → In Progress
assignee:	nobody → Mauricio Faria de Oliveira (mfo)

Mauricio Faria de Oliveira (mfo) on 2022-10-20

tags:

added: sts

Revision history for this message

Mauricio Faria de Oliveira (mfo) wrote on 2022-10-26:

https://github.com/canonical/subiquity/commit/bccdff2792a89281cfe74d2b8dc1cc14fcd3b69e

Changed in subiquity:
status:	In Progress → Fix Released

Revision history for this message

Mauricio Faria de Oliveira (mfo) wrote on 2022-10-26:

Oops, please read Fix Committed (can't change it back; sorry).

It's still in the snap edge channel.

Please note that, at the moment, the version string won't
allow even `refresh-installer.channel=edge` to pick it up
on 22.04+, but it should get there at some point.

For testing purposes, one can switch into a terminal with
eg, ctrl-alt-f2 and force `snap refresh --edge subiquity`.

$ snap info subiquity
...
latest/edge: 22.02.2+git777.bccdff27 2022-10-26 (4033) 27MB classic

Dan Bungert (dbungert) on 2022-10-26