SubDownloader

Extra option to show uploader in the subtitle filename

Bug #628901 reported by Ivan Garcia on 2010-09-02

8

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	SubDownloader	Fix Committed	Wishlist	Marco Rodrigues	SubDownloader 2.0.15

Bug Description

When multiple subtitles exist for the same movie, it would be nice to be able to do name the subtitles like this: moviefilename.languageXXX.uploader.srt

For now I accomplished it by doing this:

elif optionSubtitleName == QVariant("SAME_VIDEOPLUSLANG"):
subFileName = without_extension(video.getFileName()) +"." +subtitle.getLanguageXXX() +"." +subtitle.getUploader()+"." + sub_extension

A more proper configurable solution would be nice.

Revision history for this message

Ivan Garcia (capiscuas) wrote on 2010-09-02:

#1

Thanks,

if you go deeper and can configure the QT part that would be awesome.

BTW, what is the interest to show also the uploader in the filename?

Revision history for this message

Jeppe Dam (jeppedam) wrote on 2010-09-02: Re: [Bug 628901] Re: Extra option to show uploader in the subtitle filename

#2

I would like the uploader to be shown since that helps identify the
good subtitles. This way you know whose subtitles to prefer for later
episodes. Also it makes it easier to download more subtitles for the
same episode should one of them turn out to be of poor quality.

I will try to make the required changes, but I must warn you that I have
never written anything i Python.

/Jeppe

On 02-09-2010 17:30, Ivan Garcia wrote:
> Thanks,
>
> if you go deeper and can configure the QT part that would be awesome.
>
> BTW, what is the interest to show also the uploader in the filename?
>

Revision history for this message

Jeppe Dam (jeppedam) wrote on 2010-09-02:

#3

full source file of changes and also a bzr diff >gui.patch file attached. Edit (29.9 KiB, application/zip)

Here is my attempt to implement this feature.
Note that I am a newbie at Python and Bazar, but it seems to work as intended.

Revision history for this message

Marco Rodrigues (gothicx) wrote on 2010-10-10:

#4

Could you update patch to apply to current trunk version?

Thank you

Changed in subdownloader:
status:	New → In Progress
assignee:	nobody → Marco Rodrigues (gothicx)

Revision history for this message

Jeppe Dam (jeppedam) wrote on 2010-10-11:

#5

updated for rev 520 Edit (27.0 KiB, text/plain)

Here is an updated patch

Revision history for this message

Marco Rodrigues (gothicx) wrote on 2010-10-12:

#6

It doesn't apply cleanly in gui/preferences.ui, could you fix it please?

Thanks

Revision history for this message

Jeppe Dam (jeppedam) wrote on 2010-10-12:

#7

for v529 and cleaned up Edit (4.4 KiB, text/plain)

Here is another try. I am quite newbie with this bazaar thing. I cleaned the patch up a lot, so it should be much less changes in the problematic file now.

Revision history for this message

Marco Rodrigues (gothicx) wrote on 2010-10-13:

#8

It worked. I'll apply it to the trunk.

Thank you

Changed in subdownloader:
milestone:	none → 2.0.15
status:	In Progress → Fix Committed

Marco Rodrigues (gothicx) on 2011-02-13

Changed in subdownloader:
importance:	Undecided → Wishlist

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Related questions

SubDownloader: Option for subtitle named moviename.lang.uploader.srt

Patches

Add patch

Remote bug watches

Bug watches keep track of this bug in other bug trackers.