DC++ regenerating PID at startup if IP changed

Regardless of the technical need for this, I doubt that users interface will work as you wish. Most users won't understand the message, nor will they bother to learn what the dialog is trying to tell them. They will just think it's getting in their way of downloading files and be gone with it.

For further discussions about users and trying to forcefully make users make decisions about things they can't be expected to care about, see these well-written articles:

http://blogs.msdn.com/oldnewthing/archive/2003/09/01/54734.aspx
http://www.joelonsoftware.com/uibook/chapters/fog0000000062.html

this looks like something that could go wrong in many edge cases... eg people who don't set any IP in settings.
also, if the person who is including the bad settings file forgets to remove the "PID" line, chances are he will also forget to remove the "don't bother me again line".
and individ is right, most won't even understand what they are being asked in the first place.

the way i was initially thinking this could be solved was by saving personal settings like nick, e-mail, PID, shared files and so on in a different file, say, "Personal.xml". the guy making a pre-configured DC++ will then hopefully be smart enough not to include that "Personal.xml" file.

Unfortunately I've seen many clients with preset nicks like "[HUN]enteryournickhere". So I rather suggest "VerySecretFileDontShowAnyoneOrIllTakeControlOverYourComputer.xml"..

Btw, I support that Personal.xml idea, sounds good.

Anyway much better than the current system.
Btw, IIRC user commands are kept in the favorites.xml file too ? That's a bad idea as well since I want to share my user commands with other ops but without my favourite hubs.

Hmm, another idea. Since the PID should be unique ( time + mac ) , mac changing should be reflected in pid change.
One could pick in settings "Do not regenerate my PID when my MAC changes". This would be transparent to the regular user and it will not harass him too much.

regenerating on mac change with an option solves users copying dcplusplus.xml but not preforged clients (since they'd disable the option)

I can agree to a patch storing the hash of the mac (to avoid disclosure) and optional, default on, pid regen...

Well on preforged clients, why would they disable the option?
- if they are ignorant, then they will ignore it so it will remain checked
- if they know what it's about, then they should leave it checked. Unchecking it would have a reason only like being a mastermind that wants to kill ADC hubs and users which is hard to consider...

I added the wishlist to strongdc perhaps bigmuscle would consider writing a patch :D ( or implement it in sdc .. )