Streamtastic

Opening ShoutcastView sometimes causes "freeze" of the application

Bug #272451 reported by mikeL on 2008-09-20

Affects		Status	Importance	Assigned to	Milestone
	Streamtastic	Fix Released	Undecided	Unassigned

Bug Description

this bug occured randomly when i opened the shoutcastview after starting streamtastic. (maybe caused by an unresponsive shoutcastserver)

error prompt:

Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
at org.kuehntopf.streamtastic.gui.views.ShoutcastView$3.done(ShoutcastView.java:171)
at javax.swing.SwingWorker$5.run(Unknown Source)
at javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(Unknown Source)
at sun.swing.AccumulativeRunnable.run(Unknown Source)
at javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(Unknown Source)
at javax.swing.Timer.fireActionPerformed(Unknown Source)
at javax.swing.Timer$DoPostEvent.run(Unknown Source)
at java.awt.event.InvocationEvent.dispatch(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

way to reproduce this error:

break the network connection before starting streamtastic.

Related branches

lp://staging/~thabird/streamtastic/streamtastic-searchSC

Merged into lp://staging/streamtastic/0.3.7 at revision 30

No reviews requested

Revision history for this message

mikeL (thabird) wrote on 2008-09-20:

Bugfix for #272451

-Exceptions in SwingWorker.doInBackground() are oprressed, thus the ShoutcastFeedException could not be detected
-added check for null values to prevent NullPointerException in SwingWorker.done()
-added confirm dialog to permit retries.

-------
Note: the shoutcastfeedexception is also oppreesed when retrieving stations for a genre so it is not possible to distinguish between an empty and an not retrieved stationlist. It would be wise to add a dialog in this case to.(not included in this fix)

Revision history for this message

mikeL (thabird) wrote on 2008-09-20:

The patch from the previous comment is deprecated! Use the new patch supplied here.

Fixed Bug #272525, improved fix for Bug #272451

-eventually thrown exception in SwingWorker.doInBackground was not handled
-the exception is now handled, in case of occurance a retry offer is made

-applied new Swingworker handling to fix for Bug #272451

--------------------

Bugfix for #272451

-Exceptions in SwingWorker.doInBackground() are oprressed, thus the ShoutcastFeedException could not be detected
-Exceptions now handled in SwingWorker.done()
-added confirm dialog to permit retries.