Distribution:+ppas and Distribution:+questions issue unlimited queries when memo=0&direction=backwards
Bug #872086 reported by
William Grant
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Raphaël Badin | ||
Storm |
Fix Released
|
High
|
Raphaël Badin | ||
lazr.batchnavigator |
Fix Released
|
Low
|
Raphaël Badin |
Bug Description
The batch navigators on at least Distribution:+ppas and Distribution:
OOPS-2109ED42 and OOPS-2109EC14 are examples. The only thing I've seen using this sort of URL (apart from me when testing) is Googlebot.
Related branches
lp://staging/~rvb/storm/storm-0slice-bug-872086
- Robert Collins (community): Needs Fixing
- Thomas Herve (community): Approve
- Gavin Panella: Approve
-
Diff: 48 lines (+13/-3)3 files modifiedNEWS (+1/-0)
storm/sqlobject.py (+0/-3)
tests/sqlobject.py (+12/-0)
lp://staging/~rvb/storm/storm-0slice-bug-872086-tests
- Thomas Herve (community): Approve
- Gavin Panella: Approve
- Diff: 0 lines
lp://staging/~rvb/lazr.batchnavigator/lazr.batchnavigator-872086
- Gavin Panella: Approve
- Diff: 0 lines
lp://staging/~rvb/launchpad/storm-update-bug-872086
- Gavin Panella (community): Approve
-
Diff: 12 lines (+1/-1)1 file modifiedversions.cfg (+1/-1)
Changed in storm: | |
importance: | Undecided → High |
assignee: | nobody → Raphaël Badin (rvb) |
milestone: | none → 0.20 |
status: | New → In Progress |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Raphaël Badin (rvb) |
Changed in lazr.batchnavigator: | |
status: | New → In Progress |
assignee: | nobody → Raphaël Badin (rvb) |
importance: | Undecided → Low |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in storm: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Looks like a storm bug SQLObjectResult Set[0:0] :
{{{ interfaces. distribution import IDistributionSet interfaces. distroseries import IDistroSeriesSet IDistributionSe t).getByName( "ubuntu" ) IDistroSeriesSe t)
>>> from lp.registry.
>>> from lp.registry.
>>> ubuntu = getUtility(
>>> distroseriesset = getUtility(
>>> list(distroseri esset.search( distribution= ubuntu) ) autotest' >] backports_ not_automatic, [...] FROM DistroSeries distribution, version
[<DistroSeries u'warty'>, <DistroSeries u'hoary'>, <DistroSeries
u'grumpy'>, <DistroSeries u'breezy-
# Good
# SELECT DistroSeries.
WHERE distribution = 1 ORDER BY DistroSeries.
DistroSeries.
>>> list(distroseri esset.search( distribution= ubuntu) [1:1]) backports_ not_automatic, [...] FROM DistroSeries distribution, version LIMIT 0 OFFSET 1
[]
# Good
# SELECT DistroSeries.
WHERE distribution = 1 ORDER BY DistroSeries.
DistroSeries.
>>> list(distroseri esset.search( distribution= ubuntu) [0:0]) autotest' >] backports_ not_automatic, [...] FROM DistroSeries distribution, version
[<DistroSeries u'warty'>, <DistroSeries u'hoary'>, <DistroSeries
u'grumpy'>, <DistroSeries u'breezy-
# No limit nor offset in the generated query ... ?!
# SELECT DistroSeries.
WHERE distribution = 1 ORDER BY DistroSeries.
DistroSeries.
}}}