timeouterror could be more clear about the implications
Bug #617973 reported by
Robert Collins
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Storm |
Fix Released
|
Low
|
Jamu Kakar |
Bug Description
When TimeoutError is raised the exception looks like the query was run-and-timed-out, but actually it isn't run.
So perhaps if the exception had two parts - a reason, and the query (or perhaps a new class name?).
I'd like a reason myself:
TimeoutError('-4 seconds remaining in time budget', 'SELECT....')
TimeoutError('SQL server cancelled transaction', 'SELECT....')
The lack of clarity here means that new developers reading OOPS reports in launchpad for the first time have to go read the storm source to see what is actually meant by a TimeoutError - and they don't, because they *think* they know what TimeoutError means when they first see it.
Related branches
lp://staging/~jkakar/storm/better-timeout-messages
- Michael Hudson-Doyle: Approve
- Robert Collins (community): Approve
- Storm Developers: Pending requested
-
Diff: 135 lines (+42/-10)5 files modifiedstorm/databases/postgres.py (+2/-1)
storm/exceptions.py (+4/-2)
storm/tracer.py (+20/-2)
tests/databases/postgres.py (+3/-2)
tests/tracer.py (+13/-3)
Changed in storm: | |
milestone: | none → 0.18 |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in storm: | |
status: | Confirmed → In Progress |
assignee: | nobody → Jamu Kakar (jkakar) |
Changed in storm: | |
status: | In Progress → Fix Committed |
Changed in storm: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.